[ai] Make writable property be required in DurableAgent#stream()
#365
+26
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: aa318ce The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
pranaygp
reviewed
Nov 19, 2025
pranaygp
approved these changes
Nov 19, 2025
Co-authored-by: Pranay Prakash <[email protected]>
TooTallNate
deleted the
11-18-_ai_make_writable_property_be_required_in_durableagent_stream_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the
writableproperty required inDurableAgent#stream()method to avoid implicit default output stream behavior, which is too easy to overlook.What changed?
writableproperty inDurableAgentStreamOptionsinterface from optional to requiredwritableis now requiredWhy make this change?
Making the
writableproperty required improves code clarity and prevents potential issues from implicit behavior. By requiring explicit stream specification, it becomes more obvious where agent output is being directed, making the API more predictable and easier to understand. This change also aligns with best practices for explicit parameter requirements rather than relying on implicit defaults.