feat: add astro support #347
Conversation
🦋 Changeset detectedLatest commit: 93495f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| suppressUndefinedRejections: true, | ||
| }); | ||
|
|
||
| // // Post-process the gen // Post-process the generated file to wrap with SvelteKit request converter |
There was a problem hiding this comment.
| // // Post-process the gen // Post-process the generated file to wrap with SvelteKit request converter | |
| // Post-process the generated file to wrap with Astro request converter |
There is a malformed comment on line 151 that appears to be a copy-paste artifact, with doubled comment markers and garbled text.
View Details
Analysis
Malformed comment in AstroBuilder.buildWebhookRoute()
What fails: Line 151 in packages/astro/src/builder.ts contains a malformed comment with doubled comment markers and garbled text: // // Post-process the gen // Post-process the generated file to wrap with SvelteKit request converter
Impact: While this is only a comment and doesn't affect runtime behavior, it indicates a copy-paste artifact and incorrectly references "SvelteKit" instead of "Astro", creating confusion about the actual implementation.
Root cause: The comment was likely copied from the SvelteKit builder implementation without proper cleanup during the Astro builder implementation.
Fix: Replaced the malformed comment with a clean version that accurately describes the post-processing step for the Astro webhook route:
- Changed from:
// // Post-process the gen // Post-process the generated file to wrap with SvelteKit request converter - Changed to:
// Post-process the generated file to wrap with Astro request converter
This aligns with the comment style used in the buildStepsRoute() and buildWorkflowsRoute() methods of the same class.
Normalize trigger scripts across workbenches fix: include hono in local build test test: include src dir for test test: add workflow dir config in test to fix sveltekit dev tests add temp 7_full in example wokrflow format fix(sveltekit): detecting workflow folders and customizable dir Remove 7_full and 1_simple error replace API symlink in webpack workbench Fix sveltekit and vite tests Fix sveltekit symlinks Test fixes Fix sveltekit workflows path Dont symlink routes in vite Include e2e tests for hono and vite fix error tests post normalization wip - attempted fixes
* Proper stacktrace propogation in world Proper stacktrace propogation in world * Standardize the error type in the world spec * Normalize Workbenches Normalize trigger scripts across workbenches fix: include hono in local build test test: include src dir for test test: add workflow dir config in test to fix sveltekit dev tests add temp 7_full in example wokrflow format fix(sveltekit): detecting workflow folders and customizable dir Remove 7_full and 1_simple error replace API symlink in webpack workbench Fix sveltekit and vite tests Fix sveltekit symlinks Test fixes Fix sveltekit workflows path Dont symlink routes in vite Include e2e tests for hono and vite * fix error tests post normalization * fix(sveltekit): reading file on hmr delete * changeset * fix(vite): add resolve symlink script * fix(vite): missing building on hmr * test local builder in vite * test: increase timeout on hookWorkflow * test: ignore vite based apps in crossFileWorkflow * test: fix nitro based apps status codes * fix: intercept default vite spa handler on 404 workflow routes * fix: vite hook route returning 422 * test: use 422 for hookWorkflow expected * test: fix hono returning 404 * chore: add comment to middleware to clarify * make api route for duplicate case * revert * revert: nitro builder * add back nitro unhandled rejection logic * test: add hono * changeset * fix: unused method * fix: remove duplicate import * remove * chore: add comments to clarify * test remove vite symlink script --------- Co-authored-by: Pranay Prakash <[email protected]>
* fix: add sveltekit server routes to builder * fix: remove root workflow dir check * fix missing root level workflow route * Fix: The constructor now hardcodes `dirs: ['src/routes', 'src/lib']` which silently ignores any user\-provided `dirs` option passed to the plugin\, breaking the documented API and removing support for custom workflow directories\. * Fix: The test expectations don\'t match the new implementation of `getWorkflowDirs()`\. The mock provides `scanDirs` which the new code no longer uses\, and the new implementation adds scanning of `routesDir` and `apiDir` instead\. * fix(nitro): use src dir --------- Co-authored-by: Vercel <vercel[bot]@users.noreply.github.com> Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
adriandlam
force-pushed
the
feat/astro-support
branch
from
8bd8782 to
13e7aa7
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
adds a new package
@workflow/astrofor supporting astrowaiting on Astro #14769 to be merged to resolve
TypeErrorbeing thrown coming from undefined unhandled rejections