Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed SvelteKit related issues #7231

Closed
wants to merge 9 commits into from
Closed

Fixed SvelteKit related issues #7231

wants to merge 9 commits into from

Conversation

alec-c4
Copy link

@alec-c4 alec-c4 commented Feb 2, 2024

Description

Fixed SvelteKit related issues:

Testing Instructions

npx create-turbo@latest -e with-svelte

@alec-c4 alec-c4 requested review from anthonyshew and a team as code owners February 2, 2024 15:45
@alec-c4 alec-c4 requested a review from NicholasLYang February 2, 2024 15:45
@turbo-orchestrator turbo-orchestrator bot added area: examples Improvements or additions to examples owned-by: turborepo labels Feb 2, 2024
Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-svelte-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 3:25pm
7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 3:25pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 3:25pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 3:25pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 3:25pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 3:25pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 3:25pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 3:25pm

Copy link

vercel bot commented Feb 2, 2024

@alec-c4 is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@alec-c4
Copy link
Author

alec-c4 commented Feb 9, 2024

@anthonyshew @NicholasLYang Hey! May I ask you check what's wrong with PR?

@tknickman
Copy link
Member

Hey @alec-c4 could you fix the conflicts here? Then we should be able to get it in 👍🏼

Copy link
Member

@tknickman tknickman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts need to be resolved

@alec-c4
Copy link
Author

alec-c4 commented Apr 5, 2024

Conflicts need to be resolved

Hey @tknickman — I've resolved conflicts, but there are some issues with deployment to the Vercel :(

SCR-20240405-pydt

@alec-c4 alec-c4 requested a review from tknickman April 5, 2024 15:13
Copy link
Member

@tknickman tknickman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the pnpm lock file for the example is out of date and that's why the install is failing on Vercel. A pnpm install should fix it up!

@anthonyshew
Copy link
Contributor

Looks like this one has fallen stale. I believe it's also been superceded by other work.

Feel free to open a PR with any more improvements you see with today's iterations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ci area: examples Improvements or additions to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants