New Vite requirements gives warning when building "for the first time" #5390
Labels
Comments
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Make sure you have the following line in your |
It's there. I've updated this issue with my entire |
|
I just ran the following commands and didn't see any issue: |
|
@phenomen this wouldn't fail the build, you're experiencing a different error in addition to this (harmless) warning |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Hi, I've done some testing and I'm getting the same results as you. Indeed after running However, I'm still getting these issues on Gitlab CI/CD but I think that is an issue with them since I'm not getting these errors when running the dockerfile locally on my machine. And since @Rich-Harris said it is a harmless warning (and I'm not seeing any problems) I'm fine with it. Thank you for your help! Edit: I've found out what caused the issue on Gitlab CI/CD. I didn't copy the "svelte.config.js" file before I ran "npm install" which ran "svelte-kit sync". I'm not going to clarify my weird (and now changed) Dockerfile but I wanted to update this comment since I accused Gitlab CI/CD. |
Can you link to this please? |
There you go, it's in one of the comments marked off-topic above. |
Wow ok. Thanks I completely missed that... which would be the effect of hiding things in issue threads. It seems anti productive. Just because it's off topic doesn't mean it's irrelevant. |
|
Trying to migrate a project from 5 months ago ... Created a new project Select SvelteKit and TypeScript Try to run the project Getting a little sick of the constant breaking changes on SvelteKit. |
Normally this gets generated automatically on the first startup. Maybe try the official way to create a project?
Five months ago SvelteKit was still in beta, so breaking changes were a possibility. Nevertheless, they warned people that breaking changes will occur. If I'm not mistaken it was right at the top of the README. |
|
when I am on @svektejs/kit 1.13 or 1.14 I get build fail on netlify. |
|
seems like adding |
babakfp
added a commit
to babakfp/scrollephant
that referenced
this issue
May 11, 2023
|
This just bit me on vercel, seems like it should be in the default project template. |
|
Happened to me too on Vercel. |
|
Are these new projects?
…On May 15, 2023, 23:41, at 23:41, "Vojtěch Marek" ***@***.***> wrote:
Happened to me too on Vercel.
--
Reply to this email directly or view it on GitHub:
#5390 (comment)
You are receiving this because you modified the open/close state.
Message ID: ***@***.***>
|
|
Yes. Just recently created. The project is really basic. It was created with
|
velut
added a commit
to velut/gridify.it
that referenced
this issue
May 23, 2023
|
After new updates, getting some errors on build. Node-adaptor creates .svelte-kit folder |
|
still getting this error: |
|
When you create a new project, it's setup as: Make sure you have |
|
Not specific to you Ben, but might it be an idea to create a new issue for this? This issue has been necroed for a while now.
Get BlueMail for Android
…On Jul 24, 2023, 18:05, at 18:05, Ben McCann ***@***.***> wrote:
When you create a new project, it's setup as:
```
"scripts": {
"dev": "vite dev",
"build": "vite build",
"preview": "vite preview",
"check": "svelte-kit sync && svelte-check --tsconfig
./jsconfig.json",
"check:watch": "svelte-kit sync && svelte-check --tsconfig
./jsconfig.json --watch",
"lint": "prettier --plugin-search-dir . --check . && eslint .",
"format": "prettier --plugin-search-dir . --write .",
"test": "cross-env NODE_OPTIONS=--experimental-vm-modules jest src
--config jest.config.json",
"test:watch": "npm run test -- --watch"
},
```
Make sure you have `svelte-kit sync` in `check`
--
Reply to this email directly or view it on GitHub:
#5390 (comment)
You are receiving this because you modified the open/close state.
Message ID: ***@***.***>
|
This seems to work for me, Is this going to be the default? TS is kind of a pain, and those kind of warnings are scary for noob devs like me. |
|
This is the default, as far as I am aware.
Get BlueMail for Android
…On Jul 28, 2023, 14:42, at 14:42, srgeneroso ***@***.***> wrote:
> When you create a new project, it's setup as:
>
> ```
> "scripts": {
> "dev": "vite dev",
> "build": "vite build",
> "preview": "vite preview",
> "check": "svelte-kit sync && svelte-check --tsconfig
./jsconfig.json",
> "check:watch": "svelte-kit sync && svelte-check --tsconfig
./jsconfig.json --watch",
> "lint": "prettier --plugin-search-dir . --check . && eslint .",
> "format": "prettier --plugin-search-dir . --write .",
> "test": "cross-env NODE_OPTIONS=--experimental-vm-modules jest src
--config jest.config.json",
> "test:watch": "npm run test -- --watch"
> },
> ```
>
> Make sure you have `svelte-kit sync` in `check`
This seems to work for me, Is this going to be the default? TS is kind
of a pain, and those kind of warnings are scary for noob devs like me.
--
Reply to this email directly or view it on GitHub:
#5390 (comment)
You are receiving this because you modified the open/close state.
Message ID: ***@***.***>
|
Tyneor
added a commit
to Tyneor/crystal-melt
that referenced
this issue
Aug 27, 2023
|
To get rid of the harmless
|
|
TurboRepo users will want to add the line |
I wonder whether one would have to do something similar for Bazel. |
|
To reiterate what has been said before, the warning is supposed to be harmless. It indicates that whatever build system you use (vercel, netlify, multistage docker builds, ...) didn't populate the The This warning will happen if your build system runs Given that people on different platforms reported different workarounds, it's not really clear what sveltekit is expected to do:
A sensible thing to do IMO would be to extend the default package.json's But commenting on a closed issue won't help to make it happen. |
AlexAxthelm
added a commit
to RMI-PACTA/pacta-dashboard-svelte
that referenced
this issue
Dec 4, 2024
AlexAxthelm
added a commit
to RMI-PACTA/pacta-dashboard-svelte
that referenced
this issue
Dec 4, 2024
* Move sample data to `sample-data/` dir * Split build and (dev) serving docker images * Update README.md * Restore `COPY` on `.svelte-kit` directory * Use `npm run prepare` rather than COPY See: sveltejs/kit#5390 (comment) * Formatting * Move `npm run install` to later in docker build * Add Docker build action * Formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
Describe the bug
Hi,
If I'm not mistaken since the new build changes introduced in PR #5332 I'm getting this error when building:
Now this is quite logical because the .svelte-kit folder is in my (and this repos) .gitignore. The folder (and the tsconfig.json file) does get generated after running once, but that isn't a solution since you'd generally build in a CI/CD pipeline.
I don't know if this is a problem or not, but thought it would be better to report it in any case.
Thanks for the amazing work you all have done! :)
Reproduction
My project where this is happening: link
Logs of a CI/CD step where you can see this: link
If you want to recreate it using my repo here are the steps:
npm installnpm run buildLogs
System Info
npmPackages: @sveltejs/adapter-auto: next => 1.0.0-next.53 @sveltejs/adapter-static: ^1.0.0-next.34 => 1.0.0-next.34 @sveltejs/kit: next => 1.0.0-next.360 svelte: ^3.44.0 => 3.48.0 vite: ^2.9.13 => 2.9.13Severity
annoyance
Additional Information
My
package.jsonfile:The text was updated successfully, but these errors were encountered: