-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for manual SSL certs/keys #520
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this a lot. Adding this functionality will assist a lot of people.
Any update on this? Looks ready to me :) |
This is really needed. Please review and implement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much! This looks great.
In most cases, of course, your production environment (proxy) should be taking care of terminating the SSL setup. I do understand, however, that this can still be useful for cases where there's no proxy or for local development.
I believe this needs a simple note on documentation. I could find the usage agruments on cli but there is no docs on markdown pages |
must be in readme |
This is the work done to address #511 that I created a while back.
Essentially, it adds two optional CLI args for providing a path to an SSL cert and private key. This allows you to create certs using another tool such as mkcert and use them in
serve
.Here is a possible workflow:
This does not do any kind of cert creation, cert validation, or automatic HTTPS - it just lets you serve with HTTPS if you happen to have certs already.