Support HTTPS #274

justanotherdot · 2017-10-11T03:19:46Z

This should hopefully resolve #178. It uses the example given in the
micro examples of with-https. It has some rough edges still that
needed to be sanded down:

Choosing a specific short flag name for ssl (and if the initial flag
should still be called ssl; I'm tempted to rename it to https or what
have you) - would like if someone chimed in about their design thoughts for this.
The example always acks with 200 and the example object - should just be a matter of passing off the handler as fn to microHttps.
It does not support compression and merely overwrites the previous
server var - should also be trivial, just compress the handler before handing it off to whichever server will take it.

This should hopefully resolve #178. It uses the example given in the `micro` examples of `with-https`. It has some rough edges still that needed to be sanded down: * Choosing a specific short flag name for ssl (and if the initial flag should still be called ssl; I'm tempted to rename it to `https` or what have you). * The example always acks with 200 and the example object. * It does not support compression and merely overwrites the previous server var.

justanotherdot · 2017-10-11T03:20:54Z

I should be able to get to last two bullet points without much delay; the first needs someone to chime in on design wise. I'm also aiming to do some general cleanup with what I've introduced so it's not entirely set in stone yet but I'm happy to oblige any changes needed. 🙂

This also calls `compress' on the handler when the `unzipped' flag is not present.

justanotherdot · 2017-10-11T04:14:36Z

Last commit should resolve the latter two bullet points; just need to know if we should change the flag name? (I'm going to vote 'yes'! Maybe https?)

justanotherdot · 2017-10-11T20:42:50Z

Also just realized there should probably be:

~~a check for at least min of node v7.6 to support the async keyword unless it's unnecessary.~~ Noticed that I had taken out the async keyword so this is no longer true.
a way to pass the cert + key manually if one is inclined to do so, although I think I can save that for another PR if people are inclined to have it. I'm not sure about the design goals of serve especially in the context of zeit now.

Looks like http-serve has --ssl and -S for the flags they use, ~~so it might be ok to keep it and introduce -S here for consistency.~~ and it looks like we're already using -S here, so not sure what to put as an alternative.

leo

Fantastic PR! 😊

I added a few comments. I think we can release it after you've made the changes and then add support for custom certs if anyone is requesting it. I personally don't see a need for that.

Also please resolve the conflicts! 🙏

leo · 2017-10-16T09:01:09Z

lib/options.js

+  },
+  {
+    name: 'ssl',
+    description: 'Serve with ssl',


Serve content using SSL

Sounds good; wasn't sure what the ideal copy was so I figured someone would eventually chime in 😉

leo · 2017-10-16T09:01:34Z

bin/serve.js

+  key: cert.key,
+  cert: cert.cert,
+  passphrase: cert.passphrase
+}


Please add a newline after this line 😊

leo · 2017-10-16T09:01:54Z

bin/serve.js

@@ -4,6 +4,7 @@
 const path = require('path')

 // Packages
+const https = require('https')


This is not a package - it needs to be part of the "Native" import group.

Sure thing; force of habit to add to the end and glossed over the comments 🙂

justanotherdot · 2017-10-16T20:44:53Z

Thanks! I'll be sure to run npm to update thepackage-lock.json 😄

justanotherdot · 2017-10-16T21:35:53Z

Per lib/server.js conflicts, I think the global version of prettier I have installed may be reintroducing that (package.json shows v1.7.3 whereas I'm running v1.7.4). I'll resolve here to circumvent it running.

Per package-lock.json I'll just resolve to what master has for now.

justanotherdot · 2017-10-16T21:50:25Z

Should be good, and should also be using the appropriate non-master (npm install) package-lock.json. 👍

I am a little worried I didn't update the ava snapshots correctly, though. It looks like the generated markdown swapped the position of the regular and minimist options. If someone can chime in about that I'd appreciate it 😄

leo · 2017-10-17T10:17:07Z

Thank you so much! I'll make sure to update the snapshots and lockfiles to be really sure.

albinekb · 2017-10-17T10:39:56Z

:nice: use of the micro example 👍

justanotherdot · 2017-10-17T20:24:22Z

No worries, and thanks for writing that example, @albinekb! Make hacking up the diff a snap 👌

albinekb · 2017-10-17T20:47:50Z

OSS FTW! 💯 👊

jadbox · 2018-08-09T19:28:30Z

This needs documentation in the README.

plaffitt · 2019-06-07T15:14:16Z

Does this feature has been disabled? The --ssl flag doesn't exists anymore, and neither nothing related to it in the --help flag.

devinrhode2 · 2019-10-04T16:50:35Z

Indeed need documentation! I don't know what to do

nermin99 · 2020-08-13T06:40:23Z

@justanotherdot What happened to your flag? The --ssl flag doesn't work anymore and there's only --ssl-cert and --ssl-key.

justanotherdot · 2020-08-13T07:30:16Z

I am unsure I’m afraid. I was not responsible for the change removed the flag. Looks like those new flags made their way in over at #520

…

On Thu, 13 Aug 2020 at 4:40 pm Nermin Skenderovic ***@***.***> wrote: @justanotherdot <https://github.com/justanotherdot> What happened to your flag? The --ssl flag doesn't work anymore and there's only --ssl-cert and --ssl-key. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#274 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABI2FECNMQHOUTMKMPJAVGTSAODGLANCNFSM4D6TOCHA> .

nermin99 · 2020-08-13T10:14:07Z

@leo why was support for automatic HTTPS removed? As per #520 and #511 it is understandable that users might want to use manual certs and keys, but there is still, no even more, use cases for automatic SSL/HTTPS. One of the biggest reasons why serve is so popular is because it's a one-line command to literally "serve" your application. If a user wants or for some reason needs HTTPS they don't wanna have to go through a whole process of installing another tool just to get it.

Personally I stumbled upon serve when building my create-react-app and wanted to "serve" it. But because I use service workers and push notifications I need to serve it over HTTPS so I can test on other devices on the network. Sure I can get HTTPS for my self as per #520, but my co-workers can't, since they might not have their own manual certs and keys... you see the problem?

There is no reason why both manual and automatic HTTPS can't be supported.

Pass appropriate handler to https server

abb9c66

This also calls `compress' on the handler when the `unzipped' flag is not present.

leo suggested changes Oct 16, 2017

View reviewed changes

leo added the minor label Oct 16, 2017

leo mentioned this pull request Oct 16, 2017

SPA caching is incorrectly applied to index.html #258

Closed

Ryan James Spencer added 4 commits October 17, 2017 07:49

Move https import to appropriate section

90ed1d8

Change SSL flag copy

010a4dd

Merge in master to update package-lock.json

2fa4015

Address conflicts

5ac6e51

Ryan James Spencer and others added 3 commits October 17, 2017 08:36

Use master package-lock.json to avoid conflicts

b1a443f

Merge branch 'master' into justanotherdot/support-https

d9cb853

Make travis happy by updating ava snapshots

ec47459

Fix sha1 to sha512 flipping per npm 5.3.0 issue

27616ff

leo approved these changes Oct 17, 2017

View reviewed changes

leo merged commit c6336ea into vercel:master Oct 17, 2017

justanotherdot deleted the justanotherdot/support-https branch October 17, 2017 10:27

csi-lk mentioned this pull request Apr 3, 2019

SSL/TLS/HTTPS Support (yes, another one) #511

Closed

nermin99 mentioned this pull request Aug 13, 2020

Enable both manual and automatic HTTPS/SSL mode #627

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support HTTPS #274

Support HTTPS #274

justanotherdot commented Oct 11, 2017

justanotherdot commented Oct 11, 2017 •

edited

Loading

justanotherdot commented Oct 11, 2017

justanotherdot commented Oct 11, 2017 •

edited

Loading

leo left a comment •

edited

Loading

leo Oct 16, 2017

justanotherdot Oct 16, 2017

leo Oct 16, 2017

justanotherdot Oct 16, 2017 •

edited

Loading

leo Oct 16, 2017

justanotherdot Oct 16, 2017

justanotherdot commented Oct 16, 2017

justanotherdot commented Oct 16, 2017 •

edited

Loading

justanotherdot commented Oct 16, 2017 •

edited

Loading

leo commented Oct 17, 2017

albinekb commented Oct 17, 2017

justanotherdot commented Oct 17, 2017

albinekb commented Oct 17, 2017 •

edited

Loading

jadbox commented Aug 9, 2018

plaffitt commented Jun 7, 2019

devinrhode2 commented Oct 4, 2019

nermin99 commented Aug 13, 2020

justanotherdot commented Aug 13, 2020 via email

nermin99 commented Aug 13, 2020 •

edited

Loading

Support HTTPS #274

Support HTTPS #274

Conversation

justanotherdot commented Oct 11, 2017

justanotherdot commented Oct 11, 2017 • edited Loading

justanotherdot commented Oct 11, 2017

justanotherdot commented Oct 11, 2017 • edited Loading

leo left a comment • edited Loading

Choose a reason for hiding this comment

leo Oct 16, 2017

Choose a reason for hiding this comment

justanotherdot Oct 16, 2017

Choose a reason for hiding this comment

leo Oct 16, 2017

Choose a reason for hiding this comment

justanotherdot Oct 16, 2017 • edited Loading

Choose a reason for hiding this comment

leo Oct 16, 2017

Choose a reason for hiding this comment

justanotherdot Oct 16, 2017

Choose a reason for hiding this comment

justanotherdot commented Oct 16, 2017

justanotherdot commented Oct 16, 2017 • edited Loading

justanotherdot commented Oct 16, 2017 • edited Loading

leo commented Oct 17, 2017

albinekb commented Oct 17, 2017

justanotherdot commented Oct 17, 2017

albinekb commented Oct 17, 2017 • edited Loading

jadbox commented Aug 9, 2018

plaffitt commented Jun 7, 2019

devinrhode2 commented Oct 4, 2019

nermin99 commented Aug 13, 2020

justanotherdot commented Aug 13, 2020 via email

nermin99 commented Aug 13, 2020 • edited Loading

justanotherdot commented Oct 11, 2017 •

edited

Loading

justanotherdot commented Oct 11, 2017 •

edited

Loading

leo left a comment •

edited

Loading

justanotherdot Oct 16, 2017 •

edited

Loading

justanotherdot commented Oct 16, 2017 •

edited

Loading

justanotherdot commented Oct 16, 2017 •

edited

Loading

albinekb commented Oct 17, 2017 •

edited

Loading

nermin99 commented Aug 13, 2020 •

edited

Loading