Skip to content

[DevOverlay] Fix floating header invisble on small screen #74886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devjiwonchoi merged 2 commits into from
Jan 16, 2025
Merged

[DevOverlay] Fix floating header invisble on small screen #74886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83850be
[DevOverlay] Fix floating header invisble on small screen
devjiwonchoi Jan 14, 2025
716bd0e
decouple
devjiwonchoi Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...ay/_experimental/internal/components/Errors/error-overlay-layout/error-overlay-layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import type { ErrorMessageType } from '../error-message/error-message'
import type { ErrorType } from '../error-type-label/error-type-label'

import { DialogContent, DialogFooter } from '../../Dialog'
import { Overlay } from '../../Overlay'
import {
ErrorOverlayToolbar,
styles as toolbarStyles,
Expand Down Expand Up @@ -33,6 +32,7 @@ import {
} from '../dialog/header'
import { ErrorOverlayDialogBody, DIALOG_BODY_STYLES } from '../dialog/body'
import { CALL_STACK_STYLES } from '../call-stack/call-stack'
import { OVERLAY_STYLES, ErrorOverlayOverlay } from '../overlay/overlay'

type ErrorOverlayLayoutProps = {
errorMessage: ErrorMessageType
Expand Down Expand Up @@ -69,7 +69,7 @@ export function ErrorOverlayLayout({
isTurbopack,
}: ErrorOverlayLayoutProps) {
return (
<Overlay fixed={isBuildError}>
<ErrorOverlayOverlay fixed={isBuildError}>
<ErrorOverlayDialog onClose={onClose} isTurbopack={isTurbopack}>
<DialogContent>
<ErrorOverlayFloatingHeader
Expand Down Expand Up @@ -107,11 +107,12 @@ export function ErrorOverlayLayout({
</DialogFooter>
</DialogContent>
</ErrorOverlayDialog>
</Overlay>
</ErrorOverlayOverlay>
)
}

export const styles = css`
${OVERLAY_STYLES}
${DIALOG_STYLES}
${DIALOG_HEADER_STYLES}
${DIALOG_BODY_STYLES}
Expand Down
12 changes: 12 additions & 0 deletions ...components/react-dev-overlay/_experimental/internal/components/Errors/overlay/overlay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import { noop as css } from '../../../helpers/noop-template'
import { Overlay, type OverlayProps } from '../../Overlay/Overlay'

export function ErrorOverlayOverlay({ children, ...props }: OverlayProps) {
return <Overlay {...props}>{children}</Overlay>
}

export const OVERLAY_STYLES = css`
[data-nextjs-dialog-overlay] {
top: var(--size-8_5);
}
`