Skip to content

[DevOverlay] Fix floating header invisble on small screen#74886

Merged
devjiwonchoi merged 2 commits into
canaryfrom
01-15-_devoverlay_fix_floating_header_invisble_on_small_screen
Jan 16, 2025
Merged

[DevOverlay] Fix floating header invisble on small screen#74886
devjiwonchoi merged 2 commits into
canaryfrom
01-15-_devoverlay_fix_floating_header_invisble_on_small_screen

Conversation

@devjiwonchoi
Copy link
Copy Markdown
Member

@devjiwonchoi devjiwonchoi commented Jan 14, 2025

This PR fixed the floating header being invisible when the screen height was small.

Before

CleanShot 2025-01-15 at 07 35 46

After

CleanShot 2025-01-15 at 07 35 57

Closes NDX-661

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jan 14, 2025
Copy link
Copy Markdown
Member Author

devjiwonchoi commented Jan 14, 2025

@devjiwonchoi devjiwonchoi marked this pull request as ready for review January 14, 2025 22:41
@ijjk
Copy link
Copy Markdown
Member

ijjk commented Jan 14, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-15-_devoverlay_fix_floating_header_invisble_on_small_screen Change
buildDuration 16.7s 15s N/A
buildDurationCached 14.2s 12s N/A
nodeModulesSize 418 MB 418 MB ⚠️ +14.6 kB
nextStartRea..uration (ms) 417ms 421ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 01-15-_devoverlay_fix_floating_header_invisble_on_small_screen Change
5306-HASH.js gzip 53.9 kB 53.9 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 34.2 kB 34.2 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 52.9 kB 52.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 01-15-_devoverlay_fix_floating_header_invisble_on_small_screen Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js 01-15-_devoverlay_fix_floating_header_invisble_on_small_screen Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 01-15-_devoverlay_fix_floating_header_invisble_on_small_screen Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 01-15-_devoverlay_fix_floating_header_invisble_on_small_screen Change
index.html gzip 524 B 523 B N/A
link.html gzip 539 B 537 B N/A
withRouter.html gzip 520 B 520 B
Overall change 520 B 520 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 01-15-_devoverlay_fix_floating_header_invisble_on_small_screen Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 208 kB 208 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 01-15-_devoverlay_fix_floating_header_invisble_on_small_screen Change
middleware-b..fest.js gzip 670 B 667 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-15-_devoverlay_fix_floating_header_invisble_on_small_screen Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 373 kB 374 kB ⚠️ +230 B
app-page-exp..prod.js gzip 130 kB 130 kB
app-page-tur..prod.js gzip 143 kB 143 kB
app-page-tur..prod.js gzip 139 kB 139 kB
app-page.run...dev.js gzip 361 kB 362 kB ⚠️ +236 B
app-page.run..prod.js gzip 126 kB 126 kB
app-route-ex...dev.js gzip 37.6 kB 37.6 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.47 MB 2.47 MB ⚠️ +466 B
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-15-_devoverlay_fix_floating_header_invisble_on_small_screen Change
0.pack gzip 2.1 MB 2.1 MB ⚠️ +4.82 kB
index.pack gzip 74.8 kB 75.6 kB ⚠️ +855 B
Overall change 2.17 MB 2.18 MB ⚠️ +5.67 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page.runtime.dev.js
failed to diff
Commit: 716bd0e

@devjiwonchoi devjiwonchoi merged commit 2398bc6 into canary Jan 16, 2025
@devjiwonchoi devjiwonchoi deleted the 01-15-_devoverlay_fix_floating_header_invisble_on_small_screen branch January 16, 2025 12:39
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jan 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants