Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace polyfill.io in an example #62778

Closed
wants to merge 4 commits into from
Closed

Conversation

seiry
Copy link
Contributor

@seiry seiry commented Mar 3, 2024

https://polyfill.io/ is suffering a supply chian attack. Replace it with the cloudflare one. Though it's an example, still may pose risks

ref: https://blog.cloudflare.com/polyfill-io-now-available-on-cdnjs-reduce-your-supply-chain-risk
polyfillpolyfill/polyfill-service#2834

@ijjk ijjk added the examples Issue/PR related to examples label Mar 3, 2024
@ijjk
Copy link
Member

ijjk commented Mar 3, 2024

Allow CI Workflow Run

  • approve CI run for commit: 19f2ef9

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@seiry seiry marked this pull request as ready for review March 3, 2024 04:03
@seiry seiry requested review from a team as code owners March 3, 2024 04:03
@seiry seiry requested review from ismaelrumzan and delbaoliveira and removed request for a team March 3, 2024 04:03
@seiry seiry changed the title replace polyfill.io in a example replace polyfill.io in an example Mar 3, 2024
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samcx samcx enabled auto-merge (squash) March 8, 2024 01:12
@ijjk
Copy link
Member

ijjk commented Mar 8, 2024

Failing test suites

Commit: ff65c85

pnpm test-dev test/e2e/app-dir/app/index.test.ts (PPR)

  • app dir - basic > known bugs > should support React cache > server component client-navigation
Expand output

● app dir - basic › known bugs › should support React cache › server component client-navigation

expect(received).toBe(expected) // Object.is equality

Expected: "0.5510746042855672"
Received: "0.7718537634819111"

  1424 |           const val1 = await browser.elementByCss('#value-1').text()
  1425 |           const val2 = await browser.elementByCss('#value-2').text()
> 1426 |           expect(val1).toBe(val2)
       |                        ^
  1427 |         })
  1428 |
  1429 |         it('client component', async () => {

  at Object.toBe (e2e/app-dir/app/index.test.ts:1426:24)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Mar 8, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary seiry/next.js replace-polyfillio Change
buildDuration 13.9s 14s N/A
buildDurationCached 7.6s 6.3s N/A
nodeModulesSize 198 MB 198 MB
nextStartRea..uration (ms) 435ms 438ms N/A
Client Bundles (main, webpack)
vercel/next.js canary seiry/next.js replace-polyfillio Change
2453-HASH.js gzip 30.5 kB 30.5 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB N/A
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 241 B 241 B
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 45.6 kB 45.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary seiry/next.js replace-polyfillio Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary seiry/next.js replace-polyfillio Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.21 kB 4.21 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.57 kB 6.57 kB
Client Build Manifests
vercel/next.js canary seiry/next.js replace-polyfillio Change
_buildManifest.js gzip 481 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary seiry/next.js replace-polyfillio Change
index.html gzip 529 B 528 B N/A
link.html gzip 541 B 542 B N/A
withRouter.html gzip 524 B 524 B
Overall change 524 B 524 B
Edge SSR bundle Size
vercel/next.js canary seiry/next.js replace-polyfillio Change
edge-ssr.js gzip 95.1 kB 95.1 kB N/A
page.js gzip 3.06 kB 3.07 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary seiry/next.js replace-polyfillio Change
middleware-b..fest.js gzip 626 B 624 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 990 B 990 B
Next Runtimes
vercel/next.js canary seiry/next.js replace-polyfillio Change
app-page-exp...dev.js gzip 171 kB 171 kB
app-page-exp..prod.js gzip 96.5 kB 96.5 kB
app-page-tur..prod.js gzip 98.2 kB 98.2 kB
app-page-tur..prod.js gzip 92.7 kB 92.7 kB
app-page.run...dev.js gzip 149 kB 149 kB
app-page.run..prod.js gzip 91.2 kB 91.2 kB
app-route-ex...dev.js gzip 21.3 kB 21.3 kB
app-route-ex..prod.js gzip 15 kB 15 kB
app-route-tu..prod.js gzip 15 kB 15 kB
app-route-tu..prod.js gzip 14.8 kB 14.8 kB
app-route.ru...dev.js gzip 20.9 kB 20.9 kB
app-route.ru..prod.js gzip 14.8 kB 14.8 kB
pages-api-tu..prod.js gzip 9.52 kB 9.52 kB
pages-api.ru...dev.js gzip 9.8 kB 9.8 kB
pages-api.ru..prod.js gzip 9.52 kB 9.52 kB
pages-turbo...prod.js gzip 22.3 kB 22.3 kB
pages.runtim...dev.js gzip 22.9 kB 22.9 kB
pages.runtim..prod.js gzip 22.3 kB 22.3 kB
server.runti..prod.js gzip 50.5 kB 50.5 kB
Overall change 947 kB 947 kB
build cache Overall increase ⚠️
vercel/next.js canary seiry/next.js replace-polyfillio Change
0.pack gzip 1.56 MB 1.55 MB N/A
index.pack gzip 105 kB 106 kB ⚠️ +1.2 kB
Overall change 105 kB 106 kB ⚠️ +1.2 kB
Diff details
Diff for middleware.js

Diff too large to display

Commit: ff65c85

@styfle
Copy link
Member

styfle commented Mar 8, 2024

Closing as a duplicate of #62719

@styfle styfle closed this Mar 8, 2024
auto-merge was automatically disabled March 8, 2024 14:11

Pull request was closed

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants