Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint): enhance no-unwanted-polyfill w/ new endpoints #62719

Merged
merged 6 commits into from
Mar 6, 2024

Conversation

SukkaW
Copy link
Contributor

@SukkaW SukkaW commented Mar 1, 2024

The PR adds the new polyfill.io instance endpoint (from Fastly and Cloudflare) to the eslint-plugin-next's no-unwanted-polyfillio rules, so these new endpoints can be detected by the rule.


polyfill.io was acquired by a China-based CDN company "Funnull", see the announcement from the polyfill.io domain owner's Twitter and https://github.com/polyfillpolyfill/polyfill-service/issues/2834. Despite Funnull's claims of operating in the United States, the predominance of Simplified Chinese on its website suggests otherwise, and it turns out that "Funnull" is notorious for providing service for the betting and pornography industries.

The original creator of the polyfill.io has voiced his concern on Twitter. And since the acquisition, numerous issues have emerged (polyfillpolyfill/polyfill-service#2835, polyfillpolyfill/polyfill-service#2838, AlistGo/alist#6100), rendering the polyfill.io service extremely unstable. Since then, Fastly (Announcement) and Cloudflare (Announcement) has hosted their own instances of polyfill.io service.

@ijjk
Copy link
Member

ijjk commented Mar 1, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary SukkaW/next.js replace-polyfill-io Change
buildDuration 17.1s 17s N/A
buildDurationCached 10.4s 8.1s N/A
nodeModulesSize 198 MB 198 MB
nextStartRea..uration (ms) 494ms 500ms N/A
Client Bundles (main, webpack)
vercel/next.js canary SukkaW/next.js replace-polyfill-io Change
2453-HASH.js gzip 30.5 kB 30.5 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB N/A
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 32.1 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 45.4 kB 45.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary SukkaW/next.js replace-polyfill-io Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary SukkaW/next.js replace-polyfill-io Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.2 kB 4.2 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.56 kB 6.56 kB
Client Build Manifests
vercel/next.js canary SukkaW/next.js replace-polyfill-io Change
_buildManifest.js gzip 483 B 485 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary SukkaW/next.js replace-polyfill-io Change
index.html gzip 528 B 529 B N/A
link.html gzip 542 B 541 B N/A
withRouter.html gzip 524 B 523 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary SukkaW/next.js replace-polyfill-io Change
edge-ssr.js gzip 95 kB 95 kB N/A
page.js gzip 3.06 kB 3.07 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary SukkaW/next.js replace-polyfill-io Change
middleware-b..fest.js gzip 622 B 625 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 990 B 990 B
Next Runtimes
vercel/next.js canary SukkaW/next.js replace-polyfill-io Change
app-page-exp...dev.js gzip 171 kB 171 kB
app-page-exp..prod.js gzip 96.7 kB 96.7 kB
app-page-tur..prod.js gzip 98.5 kB 98.5 kB
app-page-tur..prod.js gzip 92.9 kB 92.9 kB
app-page.run...dev.js gzip 149 kB 149 kB
app-page.run..prod.js gzip 91.4 kB 91.4 kB
app-route-ex...dev.js gzip 21.3 kB 21.3 kB
app-route-ex..prod.js gzip 15 kB 15 kB
app-route-tu..prod.js gzip 15 kB 15 kB
app-route-tu..prod.js gzip 14.8 kB 14.8 kB
app-route.ru...dev.js gzip 21 kB 21 kB
app-route.ru..prod.js gzip 14.8 kB 14.8 kB
pages-api-tu..prod.js gzip 9.54 kB 9.54 kB
pages-api.ru...dev.js gzip 9.81 kB 9.81 kB
pages-api.ru..prod.js gzip 9.54 kB 9.54 kB
pages-turbo...prod.js gzip 22.3 kB 22.3 kB
pages.runtim...dev.js gzip 23 kB 23 kB
pages.runtim..prod.js gzip 22.3 kB 22.3 kB
server.runti..prod.js gzip 50.6 kB 50.6 kB
Overall change 949 kB 949 kB
build cache Overall increase ⚠️
vercel/next.js canary SukkaW/next.js replace-polyfill-io Change
0.pack gzip 1.55 MB 1.56 MB ⚠️ +3.87 kB
index.pack gzip 105 kB 105 kB ⚠️ +499 B
Overall change 1.66 MB 1.66 MB ⚠️ +4.37 kB
Diff details
Diff for middleware.js

Diff too large to display

Commit: 0ce9447

@SukkaW SukkaW requested review from a team as code owners March 1, 2024 10:38
@SukkaW SukkaW requested review from jh3y and molebox and removed request for a team March 1, 2024 10:38
@ijjk ijjk added the examples Issue/PR related to examples label Mar 1, 2024
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@styfle styfle enabled auto-merge (squash) March 6, 2024 16:29
@styfle styfle merged commit c206d89 into vercel:canary Mar 6, 2024
60 of 61 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
@SukkaW SukkaW deleted the replace-polyfill-io branch June 28, 2024 02:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples locked type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants