tests: fail when cannot replace content #14087

Timer · 2020-06-11T17:38:55Z

ijjk · 2020-06-11T17:46:45Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
buildDuration	12s	12.1s	⚠️ +76ms
nodeModulesSize	64.9 MB	64.9 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.055	2.048	-0.01
/ avg req/sec	1216.45	1220.64	⚠️ +4.19
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.143	1.239	⚠️ +0.1
/error-in-render avg req/sec	2187.71	2017.04	-170.67

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
main-HASH.js gzip	6.49 kB	6.49 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..0538.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
main-HASH.module.js gzip	5.58 kB	5.58 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
hooks.js gzip	881 B	881 B	✓
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
Overall change	8.22 kB	8.22 kB	✓

Client Pages Modern

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
index.module.js gzip	223 B	223 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
_app.module.js gzip	604 B	604 B	✓
Overall change	5.33 kB	5.33 kB	✓

Client Build Manifests

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
_buildManifest.js gzip	270 B	270 B	✓
_buildManife..dule.js gzip	275 B	275 B	✓
Overall change	545 B	545 B	✓

Rendered Page Sizes

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
index.html gzip	954 B	954 B	✓
link.html gzip	961 B	961 B	✓
withRouter.html gzip	947 B	947 B	✓
Overall change	2.86 kB	2.86 kB	✓

Serverless Mode

General

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
buildDuration	13.1s	13.4s	⚠️ +285ms
nodeModulesSize	64.9 MB	64.9 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
main-HASH.js gzip	6.49 kB	6.49 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..0538.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
main-HASH.module.js gzip	5.58 kB	5.58 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
hooks.js gzip	881 B	881 B	✓
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
Overall change	8.22 kB	8.22 kB	✓

Client Pages Modern

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
index.module.js gzip	223 B	223 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
_app.module.js gzip	604 B	604 B	✓
Overall change	5.33 kB	5.33 kB	✓

Client Build Manifests

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
_buildManifest.js gzip	270 B	270 B	✓
_buildManife..dule.js gzip	275 B	275 B	✓
Overall change	545 B	545 B	✓

Serverless bundles

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
_error.js	875 kB	875 kB	✓
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	875 kB	875 kB	✓
link.js	913 kB	913 kB	✓
routerDirect.js	905 kB	905 kB	✓
withRouter.js	905 kB	905 kB	✓
Overall change	4.48 MB	4.48 MB	✓

ijjk · 2020-06-11T17:47:51Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
buildDuration	10.7s	10.6s	-97ms
nodeModulesSize	64.9 MB	64.9 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.814	1.814	✓
/ avg req/sec	1378.46	1378	-0.46
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.214	1.201	-0.01
/error-in-render avg req/sec	2058.65	2081.84	⚠️ +23.19

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
main-HASH.js gzip	6.49 kB	6.49 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..0538.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
main-HASH.module.js gzip	5.58 kB	5.58 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
hooks.js gzip	881 B	881 B	✓
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
Overall change	8.22 kB	8.22 kB	✓

Client Pages Modern

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
index.module.js gzip	223 B	223 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
_app.module.js gzip	604 B	604 B	✓
Overall change	5.33 kB	5.33 kB	✓

Client Build Manifests

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
_buildManifest.js gzip	270 B	270 B	✓
_buildManife..dule.js gzip	275 B	275 B	✓
Overall change	545 B	545 B	✓

Rendered Page Sizes

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
index.html gzip	954 B	954 B	✓
link.html gzip	961 B	961 B	✓
withRouter.html gzip	947 B	947 B	✓
Overall change	2.86 kB	2.86 kB	✓

Serverless Mode

General

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
buildDuration	11.3s	11.3s	-40ms
nodeModulesSize	64.9 MB	64.9 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
main-HASH.js gzip	6.49 kB	6.49 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..0538.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
main-HASH.module.js gzip	5.58 kB	5.58 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
hooks.js gzip	881 B	881 B	✓
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
Overall change	8.22 kB	8.22 kB	✓

Client Pages Modern

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
index.module.js gzip	223 B	223 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
_app.module.js gzip	604 B	604 B	✓
Overall change	5.33 kB	5.33 kB	✓

Client Build Manifests

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
_buildManifest.js gzip	270 B	270 B	✓
_buildManife..dule.js gzip	275 B	275 B	✓
Overall change	545 B	545 B	✓

Serverless bundles

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
_error.js	875 kB	875 kB	✓
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	875 kB	875 kB	✓
link.js	913 kB	913 kB	✓
routerDirect.js	905 kB	905 kB	✓
withRouter.js	905 kB	905 kB	✓
Overall change	4.48 MB	4.48 MB	✓

ijjk · 2020-06-11T17:51:43Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
buildDuration	12.8s	12.9s	⚠️ +106ms
nodeModulesSize	64.9 MB	64.9 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.233	2.183	-0.05
/ avg req/sec	1119.56	1145.15	⚠️ +25.59
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.446	1.418	-0.03
/error-in-render avg req/sec	1729.12	1762.89	⚠️ +33.77

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
main-HASH.js gzip	6.49 kB	6.49 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..0538.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
main-HASH.module.js gzip	5.58 kB	5.58 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
hooks.js gzip	881 B	881 B	✓
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
Overall change	8.22 kB	8.22 kB	✓

Client Pages Modern

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
index.module.js gzip	223 B	223 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
_app.module.js gzip	604 B	604 B	✓
Overall change	5.33 kB	5.33 kB	✓

Client Build Manifests

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
_buildManifest.js gzip	270 B	270 B	✓
_buildManife..dule.js gzip	275 B	275 B	✓
Overall change	545 B	545 B	✓

Rendered Page Sizes

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
index.html gzip	954 B	954 B	✓
link.html gzip	961 B	961 B	✓
withRouter.html gzip	947 B	947 B	✓
Overall change	2.86 kB	2.86 kB	✓

Serverless Mode

General

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
buildDuration	13.8s	13.9s	⚠️ +147ms
nodeModulesSize	64.9 MB	64.9 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
main-HASH.js gzip	6.49 kB	6.49 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..0538.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
main-HASH.module.js gzip	5.58 kB	5.58 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
hooks.js gzip	881 B	881 B	✓
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
Overall change	8.22 kB	8.22 kB	✓

Client Pages Modern

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
index.module.js gzip	223 B	223 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
_app.module.js gzip	604 B	604 B	✓
Overall change	5.33 kB	5.33 kB	✓

Client Build Manifests

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
_buildManifest.js gzip	270 B	270 B	✓
_buildManife..dule.js gzip	275 B	275 B	✓
Overall change	545 B	545 B	✓

Serverless bundles

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
_error.js	875 kB	875 kB	✓
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	875 kB	875 kB	✓
link.js	913 kB	913 kB	✓
routerDirect.js	905 kB	905 kB	✓
withRouter.js	905 kB	905 kB	✓
Overall change	4.48 MB	4.48 MB	✓

ijjk · 2020-06-11T18:02:48Z

Failing test suites

test/integration/css/test/index.test.js

CSS Support > Ordering with Global CSS and Modules (dev) > should have the correct color (css ordering) during hot reloads

Expand output

● CSS Support › Ordering with Global CSS and Modules (dev) › should have the correct color (css ordering) during hot reloads

Failed to replace content.

Pattern: color: blue;

Content: .textModule {
  color: yellow;
}

  391 |   replace(pattern, newValue) {
  392 |     if (!this.originalContent.includes(pattern)) {
> 393 |       throw new Error(
      |             ^
  394 |         `Failed to replace content.\n\nPattern: ${pattern}\n\nContent: ${this.originalContent}`
  395 |       )
  396 |     }

  at File.replace (lib/next-test-utils.js:393:13)
  at Object.<anonymous> (integration/css/test/index.test.js:858:19)
      at runMicrotasks (<anonymous>)

ijjk · 2020-06-11T18:04:38Z

Failing test suites

test/integration/css/test/index.test.js

CSS Support > Ordering with Global CSS and Modules (dev) > should have the correct color (css ordering) during hot reloads

Expand output

● CSS Support › Ordering with Global CSS and Modules (dev) › should have the correct color (css ordering) during hot reloads

Failed to replace content.

Pattern: color: blue;

Content: .textModule {
  color: yellow;
}

  391 |   replace(pattern, newValue) {
  392 |     if (!this.originalContent.includes(pattern)) {
> 393 |       throw new Error(
      |             ^
  394 |         `Failed to replace content.\n\nPattern: ${pattern}\n\nContent: ${this.originalContent}`
  395 |       )
  396 |     }

  at File.replace (lib/next-test-utils.js:393:13)
  at Object.<anonymous> (integration/css/test/index.test.js:858:19)
      at runMicrotasks (<anonymous>)

ijjk · 2020-06-11T18:10:49Z

Failing test suites

test/integration/css/test/index.test.js

CSS Support > Ordering with Global CSS and Modules (dev) > should have the correct color (css ordering) during hot reloads

Expand output

● CSS Support › Ordering with Global CSS and Modules (dev) › should have the correct color (css ordering) during hot reloads

Failed to replace content.

Pattern: color: blue;

Content: .textModule {
  color: yellow;
}

  400 |     } else if (typeof pattern === 'string') {
  401 |       if (!this.originalContent.includes(pattern)) {
> 402 |         throw new Error(
      |               ^
  403 |           `Failed to replace content.\n\nPattern: ${pattern}\n\nContent: ${this.originalContent}`
  404 |         )
  405 |       }

  at File.replace (lib/next-test-utils.js:402:15)
  at Object.<anonymous> (integration/css/test/index.test.js:858:19)
      at runMicrotasks (<anonymous>)

ijjk · 2020-06-11T18:11:15Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
buildDuration	11.9s	12s	⚠️ +173ms
nodeModulesSize	64.9 MB	64.9 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.069	2.141	⚠️ +0.07
/ avg req/sec	1208.31	1167.59	-40.72
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.416	1.33	-0.09
/error-in-render avg req/sec	1766.08	1880.1	⚠️ +114.02

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
main-HASH.js gzip	6.49 kB	6.49 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..0538.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
main-HASH.module.js gzip	5.58 kB	5.58 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
hooks.js gzip	881 B	881 B	✓
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
Overall change	8.22 kB	8.22 kB	✓

Client Pages Modern

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
index.module.js gzip	223 B	223 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
_app.module.js gzip	604 B	604 B	✓
Overall change	5.33 kB	5.33 kB	✓

Client Build Manifests

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
_buildManifest.js gzip	270 B	270 B	✓
_buildManife..dule.js gzip	275 B	275 B	✓
Overall change	545 B	545 B	✓

Rendered Page Sizes

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
index.html gzip	954 B	954 B	✓
link.html gzip	961 B	961 B	✓
withRouter.html gzip	947 B	947 B	✓
Overall change	2.86 kB	2.86 kB	✓

Serverless Mode

General

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
buildDuration	12.8s	12.9s	⚠️ +72ms
nodeModulesSize	64.9 MB	64.9 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
main-HASH.js gzip	6.49 kB	6.49 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..0538.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
main-HASH.module.js gzip	5.58 kB	5.58 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
hooks.js gzip	881 B	881 B	✓
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
Overall change	8.22 kB	8.22 kB	✓

Client Pages Modern

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
index.module.js gzip	223 B	223 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
_app.module.js gzip	604 B	604 B	✓
Overall change	5.33 kB	5.33 kB	✓

Client Build Manifests

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
_buildManifest.js gzip	270 B	270 B	✓
_buildManife..dule.js gzip	275 B	275 B	✓
Overall change	545 B	545 B	✓

Serverless bundles

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
_error.js	875 kB	875 kB	✓
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	875 kB	875 kB	✓
link.js	913 kB	913 kB	✓
routerDirect.js	905 kB	905 kB	✓
withRouter.js	905 kB	905 kB	✓
Overall change	4.48 MB	4.48 MB	✓

ijjk · 2020-06-11T18:22:32Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
buildDuration	13.1s	13.4s	⚠️ +332ms
nodeModulesSize	64.9 MB	64.9 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.248	2.275	⚠️ +0.03
/ avg req/sec	1111.89	1098.76	-13.13
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.511	1.528	⚠️ +0.02
/error-in-render avg req/sec	1654.18	1635.92	-18.26

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
main-HASH.js gzip	6.49 kB	6.49 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..0538.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
main-HASH.module.js gzip	5.58 kB	5.58 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
hooks.js gzip	881 B	881 B	✓
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
Overall change	8.22 kB	8.22 kB	✓

Client Pages Modern

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
index.module.js gzip	223 B	223 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
_app.module.js gzip	604 B	604 B	✓
Overall change	5.33 kB	5.33 kB	✓

Client Build Manifests

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
_buildManifest.js gzip	270 B	270 B	✓
_buildManife..dule.js gzip	275 B	275 B	✓
Overall change	545 B	545 B	✓

Rendered Page Sizes

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
index.html gzip	954 B	954 B	✓
link.html gzip	961 B	961 B	✓
withRouter.html gzip	947 B	947 B	✓
Overall change	2.86 kB	2.86 kB	✓

Serverless Mode

General

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
buildDuration	14.4s	14.4s	⚠️ +11ms
nodeModulesSize	64.9 MB	64.9 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
main-HASH.js gzip	6.49 kB	6.49 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..0538.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
main-HASH.module.js gzip	5.58 kB	5.58 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.93 kB	6.93 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
hooks.js gzip	881 B	881 B	✓
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
Overall change	8.22 kB	8.22 kB	✓

Client Pages Modern

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
index.module.js gzip	223 B	223 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
_app.module.js gzip	604 B	604 B	✓
Overall change	5.33 kB	5.33 kB	✓

Client Build Manifests

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
_buildManifest.js gzip	270 B	270 B	✓
_buildManife..dule.js gzip	275 B	275 B	✓
Overall change	545 B	545 B	✓

Serverless bundles

	vercel/next.js canary	Timer/next.js fail-on-unfound-replace	Change
_error.js	875 kB	875 kB	✓
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	875 kB	875 kB	✓
link.js	913 kB	913 kB	✓
routerDirect.js	905 kB	905 kB	✓
withRouter.js	905 kB	905 kB	✓
Overall change	4.48 MB	4.48 MB	✓

ijjk · 2020-06-11T18:28:10Z

Failing test suites

test/integration/css/test/index.test.js

CSS Support > Ordering with Global CSS and Modules (dev) > should have the correct color (css ordering) during hot reloads

Expand output

● CSS Support › Ordering with Global CSS and Modules (dev) › should have the correct color (css ordering) during hot reloads

Failed to replace content.

Pattern: color: blue;

Content: .textModule {
  color: yellow;
}

  400 |     } else if (typeof pattern === 'string') {
  401 |       if (!this.originalContent.includes(pattern)) {
> 402 |         throw new Error(
      |               ^
  403 |           `Failed to replace content.\n\nPattern: ${pattern}\n\nContent: ${this.originalContent}`
  404 |         )
  405 |       }

  at File.replace (lib/next-test-utils.js:402:15)
  at Object.<anonymous> (integration/css/test/index.test.js:858:19)
      at runMicrotasks (<anonymous>)

Fixes vercel#14085

Timer requested review from ijjk, lfades and timneutkens as code owners June 11, 2020 17:38

Timer mentioned this pull request Jun 11, 2020

Automatically fail tests when our file replace utility cannot find pattern #14085

Closed

ijjk previously approved these changes Jun 11, 2020

View reviewed changes

Timer dismissed ijjk’s stale review via 7c1fdce June 11, 2020 17:43

Timer requested a review from ijjk June 11, 2020 17:44

ijjk previously approved these changes Jun 11, 2020

View reviewed changes

Timer added 3 commits June 11, 2020 14:13

tests: fail when cannot replace content

572a79b

Fix check

fd83ab2

Fix test

547ac81

Timer dismissed ijjk’s stale review via 547ac81 June 11, 2020 18:13

Timer force-pushed the fail-on-unfound-replace branch from d77fd12 to 547ac81 Compare June 11, 2020 18:13

Timer requested a review from ijjk June 11, 2020 18:14

ijjk approved these changes Jun 11, 2020

View reviewed changes

kodiakhq bot merged commit ec7c325 into vercel:canary Jun 11, 2020

Timer deleted the fail-on-unfound-replace branch June 11, 2020 18:29

darshkpatel pushed a commit to MLH-Fellowship/next.js that referenced this pull request Jun 12, 2020

tests: fail when cannot replace content (vercel#14087)

7029c2c

Fixes vercel#14085

ndom91 mentioned this pull request Jun 22, 2020

Suggestion: Separate next.js example updates / core updates in release notes #14472

Closed

rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020

tests: fail when cannot replace content (vercel#14087)

982e788

Fixes vercel#14085

vercel locked as resolved and limited conversation to collaborators Jan 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tests: fail when cannot replace content #14087

tests: fail when cannot replace content #14087

Timer commented Jun 11, 2020

ijjk commented Jun 11, 2020

ijjk commented Jun 11, 2020

ijjk commented Jun 11, 2020

ijjk commented Jun 11, 2020

ijjk commented Jun 11, 2020

ijjk commented Jun 11, 2020

ijjk commented Jun 11, 2020

ijjk commented Jun 11, 2020

ijjk commented Jun 11, 2020

tests: fail when cannot replace content #14087

tests: fail when cannot replace content #14087

Conversation

Timer commented Jun 11, 2020

ijjk commented Jun 11, 2020

Stats from current PR

ijjk commented Jun 11, 2020

Stats from current PR

ijjk commented Jun 11, 2020

Stats from current PR

ijjk commented Jun 11, 2020

Failing test suites

ijjk commented Jun 11, 2020

Failing test suites

ijjk commented Jun 11, 2020

Failing test suites

ijjk commented Jun 11, 2020

Stats from current PR

ijjk commented Jun 11, 2020

Stats from current PR

ijjk commented Jun 11, 2020

Failing test suites