Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically fail tests when our file replace utility cannot find pattern #14085

Closed
Timer opened this issue Jun 11, 2020 · 2 comments · Fixed by #14087
Closed

Automatically fail tests when our file replace utility cannot find pattern #14085

Timer opened this issue Jun 11, 2020 · 2 comments · Fixed by #14087
Assignees
@Timer
Milestone
june 2020

Comments

@Timer
Copy link
Member

Timer commented Jun 11, 2020 •
edited
Loading

Now that we automatically re-run failed tests, it's important that we don't silently succeed when we fail to replace content we expect to be replaced.

I don't expect any tests to break because of this.
@Timer Timer self-assigned this Jun 11, 2020
@Timer Timer mentioned this issue Jun 11, 2020
Merged
@Timer
Copy link
Member Author

Timer commented Jun 11, 2020

PR opened in #14087

@kodiakhq kodiakhq bot closed this as completed in #14087 Jun 11, 2020
kodiakhq bot pushed a commit that referenced this issue Jun 11, 2020
@Timer
tests: fail when cannot replace content (#14087)
ec7c325 
Fixes #14085
@Timer Timer added this to the june 2020 milestone Jun 11, 2020
darshkpatel pushed a commit to MLH-Fellowship/next.js that referenced this issue Jun 12, 2020
@Timer @darshkpatel
tests: fail when cannot replace content (vercel#14087)
7029c2c 
Fixes vercel#14085
rokinsky pushed a commit to rokinsky/next.js that referenced this issue Jul 11, 2020
@Timer @rokinsky
tests: fail when cannot replace content (vercel#14087)
982e788 
Fixes vercel#14085
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Timer Timer

Labels
None yet
Projects
None yet
Milestone
june 2020
Development

Successfully merging a pull request may close this issue.

tests: fail when cannot replace content Timer/next.js
2 participants
@Timer @balazsorban44