Add /download/dmg support
#69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://hazel-git-add-dmg.zeit.sh |
|
@leo everything's ok ? |
AndyBitz
commented
Sep 23, 2019
| @@ -23,8 +23,8 @@ | |||
| }, | |||
| "lint-staged": { | |||
| "*.js": [ | |||
| "yarn test", | |||
| "prettier --single-quote --no-semi --write", | |||
| "yarn test && :", | |||
There was a problem hiding this comment.
This was added to make sure the provided arguments from lint-staged don't cause any trouble.
See this comment from the lint-staged repo.
leo
approved these changes
Sep 23, 2019
|
👍 |
|
It doesn't seem to work, cf #53 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61
This adds
/download/dmgas a hidden route that can be used to download the latestdmgfile, if there is any.We don't add it as replacement for
/download/macto not break any clients and won't show it on the overview page since it's not a platform itself, our recommended file for mac stays.zip.