-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serve .dmg for /download/ routes #53
Conversation
Note: Downloading the .dmg requires the .zip to exist. This is because .dmg is served only on the darwin platform, which exists only if there's a .zip.
Initially I thought we could have the E.g. We'd want |
In fact I'd rather download the dmg instead of the zip from the index page. Maybe |
@julienma I am trying to use your branch, so I merged it into my branch and deployed, but |
@rwwagner90 no, it should work, as long as your This is the same branch deployed on our prod, and visiting https://download.cashnotify.com/download/ from macOS, I get a .dmg. |
@julienma how do I restart / empty the cache? I did another release just to make sure it wasn't the old release being cached, and it's still downloading the zip. My files look like this: |
@rwwagner90 not sure what to do. What happens if you browse to |
@julienma I merged in your branch into my existing Hazel project, perhaps I should also try cloning your fork directly and making a new app. |
@rwwagner90 actually I just saw there's been a fair amount of changes on To be clear: my fork's built on top of 3.0.3, and current upstream is 3.1.0. |
@julienma would it be possible to update your fork to work with current master? I am going to try your fork directly as well, but in the hopes of getting this merged eventually, it probably needs to work with the current master. |
Alternatively, could you provide instructions on how to deploy and use your fork? I tried and I got an error that there was no |
@rwwagner90 I probably won't upgrade my PR for... weeks at best, so don't wait for me :) As for
|
@julienma do you have a private GitHub repo for CashNotify? I think |
Nope, it’s public.
… Le 16 déc. 2019 à 18:47, Robert Wagner ***@***.***> a écrit :
@julienma do you have a private GitHub repo for CashNotify? I think shouldProxyPrivateDownload might be the issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
@julienma I opened a new PR which I think should fix the issue for public and private. |
Same issue here, do you know a way to fix it ? |
Fixes #41 and #29.
Note: For the .dmg to be available, the .zip file must also exist.
This is because .dmg is served only on the
darwin
platform, which only exists if there's a .zip.