Serve .dmg for /download/ routes

[julienma]

Fixes #41 and #29.

Note: For the .dmg to be available, the .zip file must also exist.
This is because .dmg is served only on the darwin platform, which only exists if there's a .zip.

[julienma]

Initially I thought we could have the dmg as a new platform, but the way aliases is made make it complicated.

E.g. /download/mac could match only 1 platform, either darwin or dmg.
This is not what we'd want.

We'd want /download/mac to match dmg platform, but /update/mac/:version to match darwin platform.

[julienma]

In fact I'd rather download the dmg instead of the zip from the index page.

Maybe .dmg should be the default (on both /download and index page), and .zip should be served only on /update/...?

[RobbieTheWagner]

@julienma I am trying to use your branch, so I merged it into my branch and deployed, but /download seems to still download the zip. Is there more setup required?

[julienma]

@rwwagner90 no, it should work, as long as your .dmg doesn't contain blockmap in its filename (cf. https://github.com/zeit/hazel/pull/53/files#diff-63fdc6a01d0ec0cbf9772723f2356e46R131). Also, maybe restart / empty cache?

This is the same branch deployed on our prod, and visiting https://download.cashnotify.com/download/ from macOS, I get a .dmg.

FWIW, here's how we name our files:

[RobbieTheWagner]

@julienma how do I restart / empty the cache? I did another release just to make sure it wasn't the old release being cached, and it's still downloading the zip.

My files look like this:

[julienma]

@rwwagner90 not sure what to do. What happens if you browse to /download/mac/ instead?

[RobbieTheWagner]

@julienma /download/mac/ also downloads the zip. Do you think the zip containing the string darwin might be making that the darwin default somehow?

I merged in your branch into my existing Hazel project, perhaps I should also try cloning your fork directly and making a new app.

[julienma]

@rwwagner90 actually I just saw there's been a fair amount of changes on master since I made that PR, and specifically one that's about serving .dmg: #69.

To be clear: my fork's built on top of 3.0.3, and current upstream is 3.1.0.
So if you applied this PR on top of current master, something weird's probably happening.

[RobbieTheWagner]

@julienma would it be possible to update your fork to work with current master? I am going to try your fork directly as well, but in the hopes of getting this merged eventually, it probably needs to work with the current master.

[RobbieTheWagner]

Alternatively, could you provide instructions on how to deploy and use your fork? I tried and I got an error that there was no now.json, so I copied the now.json from Hazel master and the app errors.

[julienma]

@rwwagner90 I probably won't upgrade my PR for... weeks at best, so don't wait for me :)

As for now.json:

• I don't deploy on Now, so can't really help on this.
• It seems now.json has been added in https://github.com/zeit/hazel/releases/tag/3.0.4 (and my fork's based on 3.0.3), so probably worth having a look to this release.

[RobbieTheWagner]

@julienma do you have a private GitHub repo for CashNotify? I think shouldProxyPrivateDownload might be the issue.

[julienma]

Nope, it’s public.

…

Le 16 déc. 2019 à 18:47, Robert Wagner ***@***.***> a écrit :  @julienma do you have a private GitHub repo for CashNotify? I think shouldProxyPrivateDownload might be the issue. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[RobbieTheWagner]

@julienma I opened a new PR which I think should fix the issue for public and private.

[Aarbel]

Same issue here, do you know a way to fix it ?
https://clovis-desktop-hazel-update-server.aarbel.now.sh/download/dmg

[RobbieTheWagner]

@Aarbel use my PR, it works #82

Would be awesome if we could get it merged, but it seems like this is not maintained.