This repository has been archived by the owner on Nov 28, 2023. It is now read-only.
fix Form ref #32
Closed
fix Form ref #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Schniz
reviewed
Nov 15, 2022
Comment on lines
36
to
41
| // 4. https://stackoverflow.com/questions/58469229/react-with-typescript-generics-while-using-react-forwardref/58473012#58473012 | ||
| declare module "react" { | ||
| function forwardRef<T, P = {}>( | ||
| render: (props: P, ref: React.ForwardedRef<T>) => React.ReactElement | null | ||
| ): (props: P & React.RefAttributes<T>) => React.ReactElement | null; | ||
| } |
There was a problem hiding this comment.
I worry about this changing customer code because AFAIK TypeScript declarations are global. Maybe we should "unsafely" type-cast?
// typed-forward-ref.ts
import { forwardRef as forwardRef_ } from "react";
const forwardRef = forwardRef_ as unknown as TYPEDEF_HERE;
export default forwardRef;wdyt? 👀
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#31