Bugfix: SectionFooterView AutoDimension Support #110

dmiluski · 2017-08-29T04:31:19Z

Problem:

I noticed our app was manually laying out subviews in our sectionFooters when I didn't see the need to. (Given auto-layout/intrinsic size support)

eg.. (Unnecessarily maintaining and calculation including insets/frame)

    override func layoutSubviews() {
        super.layoutSubviews()
        var frame = self.frame
        frame.size = CGSize(width: frame.size.width, height: signUpInstructionsLabel.systemLayoutSizeFitting(UILayoutFittingCompressedSize).height + textInsets.top + textInsets.bottom)
        self.frame = frame
    }

After recent changes, Group tableView's which had nil section extremity defaulted to zero, which drops the standard spacing between sections. (Using current master)

Notable info:
Statics currently has deploy target of iOS8, which did not yet support automatic sectionFooterView dimensioning.

Solution:

Offer autosizing option which uses UITableViewAutomaticDimension rather than view's original bounds height. Retain original .view(_) case in the event some clients were already sizing beforehand limiting integration breaks.
Bump deploy target to iOS9 for clean integration.
Revert 2 previous PRs focused on same issue

Testing:
Tested with simulators

iOS11 beta5 on iPhone 7 (Friendly)
iOS 10.3 on iPhone 6. (Requires owner to set estimatedSectionHeader/FooterHeights to > 0

Did not test on iOS 9

…ension if the view returns as 0 (venmo#109)" This reverts commit 319a8b8.

…fix" This reverts commit 2071110, reversing changes made to e002d86.

dmiluski · 2017-08-29T04:37:36Z

Hi Neal, is this change friendly to your issue you saw? Care to test with this branch?

dmiluski · 2017-08-29T04:44:31Z

@hyperspacemark @eliperkins @rhaining for further review

dmiluski · 2017-08-29T04:48:31Z

Static/Section.swift

@@ -13,6 +13,9 @@ public struct Section: Hashable, Equatable {
        /// Custom view for the header or footer. The height will be the view's `bounds.height`.
        case view(UIView)

+        // View Sized with autolayout
+        case autoLayoutView(UIView)


I'm definitely not tied to this naming since in my current case name, but wanted to convey this would handle automatic dimensioning rather than use the views set bounds.height. Only added a new case to prevent previous integration breaks.

My current use case adds stackViews without constraints, but ended up using this to not break existing .view(_) sizing.

dmiluski · 2017-10-04T01:16:50Z

@rhaining @hyperspacemark Finally found my error.

This PR works in supporting Autolayout FooterViews in iOS10/11.

BUT:
in order for it to function in iOS 10, estimatedHeights must be set > 0. I unfortunately was setting to UITableViewAutomaticDimension == -1 🤦‍♂️

Example Working:
tableView.estimatedSectionFooterHeight = 20
tableView.estimatedSectionHeaderHeight = 20

dmiluski · 2017-10-04T01:22:41Z

Static/Section.swift

@@ -13,6 +13,9 @@ public struct Section: Hashable, Equatable {
        /// Custom view for the header or footer. The height will be the view's `bounds.height`.
        case view(UIView)

+        // View Sized with autolayout
+        case autoLayoutView(UIView)


If using this view, must set estimated header/footer height to > 0, if using tableView's before iOS11

rhaining · 2017-10-04T13:54:16Z

Static/DataSource.swift

-            headerHeight = UITableViewAutomaticDimension
-        }
-        return headerHeight
+        return section(at: sectionIndex)?.header?.viewHeight ?? UITableViewAutomaticDimension


i think the thing we lose here is that if there's no header defined for this section, we're returning 'automatic dimension' now, versus in the previous code, we're returning 0 in that case.

maybe this returns 0 if the table style is 'plain', and auto dimension if the table style is 'grouped' ??

Double checking plain vs grouped once more

rhaining · 2017-10-04T13:54:24Z

Static/DataSource.swift

-            footerHeight = UITableViewAutomaticDimension
-        }
-        return footerHeight
+        return section(at: sectionIndex)?.footer?.viewHeight ?? UITableViewAutomaticDimension


similar question here

Problem: 1. I noticed our app was manually laying out subviews in our sectionFooters when I didn't see the need to. 2. After recent changes, Group tableView's which had nil section extremity defaulted to zero, which drops the standard spacing between sections. Note in attatchment. Notable info: Statics currently has deploy target of iOS8, which did not yet support automatic sectionFooterView dimensioning. Solution: - Offer autosizing option which uses UITableViewAutomaticDimension rather than view's original bounds height. Retain original .view(_) case in the event some clients were already sizing beforehand limiting integration breaks. This also offers automatic margin adherence. - Bump deploy target to iOS9 for clean integration. - Revert 2 previous PRs - Default height for plain/grouped styles to play friendly with tableView's defaults.

dmiluski · 2017-10-04T16:59:40Z

Followed up with a change for default heights.

By returning autodimension height by default, plain tableViews were taking non-standard heights with nil extremities. Update to use a default height between styles which performs equivalent to default handling if nil vs filled extremities

Also updated Example code with example of how to create an autosized extremity

Dane Miluski added 2 commits August 28, 2017 20:56

Revert "fixes footer and header heights on ios 11 to be automatic dim…

5808192

…ension if the view returns as 0 (venmo#109)" This reverts commit 319a8b8.

Revert "Merge pull request venmo#108 from nealyoung/extremity-height-…

722e5bb

…fix" This reverts commit 2071110, reversing changes made to e002d86.

dmiluski commented Aug 29, 2017

View reviewed changes

dmiluski mentioned this pull request Sep 12, 2017

fixes footer and header heights on ios 11 to be automatic dimension if the view returns as 0 #109

Merged

dmiluski commented Oct 4, 2017

View reviewed changes

dmiluski force-pushed the bugfix/headerFooterAutoLayoutSupport branch from 2d8c055 to 285bcf2 Compare October 4, 2017 01:31

rhaining reviewed Oct 4, 2017

View reviewed changes

dmiluski force-pushed the bugfix/headerFooterAutoLayoutSupport branch from 285bcf2 to 58fcb2f Compare October 4, 2017 16:45

rhaining approved these changes Oct 4, 2017

View reviewed changes

Example: AutoSized Extremity

de67897

rhaining merged commit 8ae55ef into venmo:master Oct 4, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bugfix: SectionFooterView AutoDimension Support #110

Bugfix: SectionFooterView AutoDimension Support #110

dmiluski commented Aug 29, 2017 •

edited

Loading

dmiluski commented Aug 29, 2017

dmiluski commented Aug 29, 2017

dmiluski Aug 29, 2017

dmiluski commented Oct 4, 2017

dmiluski Oct 4, 2017

rhaining Oct 4, 2017

rhaining Oct 4, 2017

dmiluski Oct 4, 2017

rhaining Oct 4, 2017

dmiluski commented Oct 4, 2017

Bugfix: SectionFooterView AutoDimension Support #110

Bugfix: SectionFooterView AutoDimension Support #110

Conversation

dmiluski commented Aug 29, 2017 • edited Loading

dmiluski commented Aug 29, 2017

dmiluski commented Aug 29, 2017

dmiluski Aug 29, 2017

Choose a reason for hiding this comment

dmiluski commented Oct 4, 2017

dmiluski Oct 4, 2017

Choose a reason for hiding this comment

rhaining Oct 4, 2017

Choose a reason for hiding this comment

rhaining Oct 4, 2017

Choose a reason for hiding this comment

dmiluski Oct 4, 2017

Choose a reason for hiding this comment

rhaining Oct 4, 2017

Choose a reason for hiding this comment

dmiluski commented Oct 4, 2017

dmiluski commented Aug 29, 2017 •

edited

Loading