-
Notifications
You must be signed in to change notification settings - Fork 87
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bugfix: SectionFooterView AutoDimension Support
Problem: 1. I noticed our app was manually laying out subviews in our sectionFooters when I didn't see the need to. 2. After recent changes, Group tableView's which had nil section extremity defaulted to zero, which drops the standard spacing between sections. Note in attatchment. Notable info: Statics currently has deploy target of iOS8, which did not yet support automatic sectionFooterView dimensioning. Solution: - Offer autosizing option which uses UITableViewAutomaticDimension rather than view's original bounds height. Retain original .view(_) case in the event some clients were already sizing beforehand limiting integration breaks. This also offers automatic margin adherence. - Bump deploy target to iOS9 for clean integration. - Revert 2 previous PRs - Default height for plain/grouped styles to play friendly with tableView's defaults.
- Loading branch information
Dane Miluski
committed
Oct 4, 2017
1 parent
722e5bb
commit 58fcb2f
Showing
3 changed files
with
23 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters