Skip to content

fix: persist early caller utterances + align opener marker rules #8423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noanflaherty merged 1 commit into from
Feb 24, 2026
Merged

fix: persist early caller utterances + align opener marker rules #8423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion assistant/src/calls/relay-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -713,7 +713,18 @@ export class RelayConnection {
if (this.controller) {
await this.controller.handleCallerUtterance(msg.voicePrompt, speaker);
} else {
// Fallback if controller not yet initialized
// Fallback if controller not yet initialized — persist the caller's
// transcript so it is available in conversation history once setup
// completes. The session pipeline normally handles persistence, but
// this early-utterance path bypasses it entirely.
if (session) {
conversationStore.addMessage(
Comment thread
noanflaherty marked this conversation as resolved.
session.conversationId,
'user',
JSON.stringify([{ type: 'text', text: msg.voicePrompt }]),
{ userMessageChannel: 'voice', assistantMessageChannel: 'voice' },
);
}
this.sendTextToken('I\'m still setting up. Please hold.', true);
}
}
Expand Down
8 changes: 4 additions & 4 deletions assistant/src/calls/voice-session-bridge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,19 +137,19 @@ function buildVoiceCallControlPrompt(opts: {
if (opts.isInbound) {
if (opts.isCallerGuardian) {
lines.push(
'10. If the latest user turn is [CALL_OPENING], this is your user calling you. Answer casually and briefly, like picking up a call from someone you know well. For example: "Hey!" or "What\'s up?" Do NOT introduce yourself, do NOT say you are calling on behalf of anyone, and do NOT ask how you can help in a formal way. Keep it short and natural.',
'10. If the latest user turn is "(call connected — deliver opening greeting)", this is your user calling you. Answer casually and briefly, like picking up a call from someone you know well. For example: "Hey!" or "What\'s up?" Do NOT introduce yourself, do NOT say you are calling on behalf of anyone, and do NOT ask how you can help in a formal way. Keep it short and natural.',
);
} else {
lines.push(
'10. If the latest user turn is [CALL_OPENING], greet the caller warmly and ask how you can help. Vary the wording; do not use a fixed template.',
'10. If the latest user turn is "(call connected — deliver opening greeting)", greet the caller warmly and ask how you can help. Vary the wording; do not use a fixed template.',
);
}
lines.push(
'11. If the latest user turn includes [CALL_OPENING_ACK], treat it as the caller acknowledging your greeting and continue the conversation naturally.',
);
} else {
lines.push(
'10. If the latest user turn is [CALL_OPENING], generate a natural, context-specific opener: briefly introduce yourself once as an assistant, state why you are calling using the Task context, and ask a short permission/check-in question. Vary the wording; do not use a fixed template.',
'10. If the latest user turn is "(call connected — deliver opening greeting)", generate a natural, context-specific opener: briefly introduce yourself once as an assistant, state why you are calling using the Task context, and ask a short permission/check-in question. Vary the wording; do not use a fixed template.',
'11. If the latest user turn includes [CALL_OPENING_ACK], treat it as the callee acknowledging your opener and continue the conversation naturally without re-introducing yourself or repeating the initial check-in question.',
);
}
Expand Down Expand Up @@ -209,7 +209,7 @@ export async function startVoiceTurn(opts: VoiceTurnOptions): Promise<VoiceTurnH
: opts.content;

// Build the call-control protocol prompt so the model knows how to emit
// control markers (ASK_GUARDIAN, END_CALL, CALL_OPENING, etc.).
// control markers (ASK_GUARDIAN, END_CALL, etc.) and recognize opener turns.
const isCallerGuardian = opts.guardianContext?.actorRole === 'guardian';

const voiceCallControlPrompt = buildVoiceCallControlPrompt({
Expand Down