fix: include runId in plain-text approval fallback for disambiguation#7518
Merged
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
Author
|
Addressed in #7571 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses Codex review feedback on #7435. When rich prompt delivery fails and falls back to plain text, the fallback now includes the runId so guardians with multiple pending approvals can disambiguate. Previously, the plain-text fallback would stall in multi-approval scenarios because handleApprovalInterception rejects decisions without a runId.
Changes:
[ref:<runId>]tag to all plain-text approval messages (both rich-fallback and non-rich channel paths)parseApprovalDecisionto extractrunIdfrom[ref:...]tags in guardian replies