Skip to content

Use generative approval copy and plain-text fallback for channel approvals#7435

Merged
noanflaherty merged 1 commit into
mainfrom
codex/assistant-generated-approval-copy
Feb 24, 2026
Merged

Use generative approval copy and plain-text fallback for channel approvals#7435
noanflaherty merged 1 commit into
mainfrom
codex/assistant-generated-approval-copy

Conversation

@noanflaherty
Copy link
Copy Markdown
Contributor

@noanflaherty noanflaherty commented Feb 24, 2026

Summary

  • route approval/guardian user-facing copy through composeApprovalMessageGenerative across channel approval routes
  • add best-effort rich-to-text fallback for approval prompts so Telegram/button failures degrade to actionable plain text
  • send non-rich channel approvals/reminders as plain text without approval metadata payloads
  • update approval route tests to validate text-fallback semantics instead of rich-delivery hard failure

Validation

  • cd assistant && bun test src/__tests__/channel-approval-routes.test.ts src/__tests__/approval-message-composer.test.ts src/__tests__/approval-hardcoded-copy-guard.test.ts
  • cd assistant && bunx tsc --noEmit (fails due pre-existing unrelated errors in src/__tests__/sms-messaging-provider.test.ts and src/daemon/handlers/config.ts)

@noanflaherty noanflaherty merged commit 0bfb6c3 into main Feb 24, 2026
1 check failed
@noanflaherty noanflaherty deleted the codex/assistant-generated-approval-copy branch February 24, 2026 01:49
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 5 additional findings.

Open in Devin Review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 78fdf043fc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread assistant/src/runtime/routes/channel-routes.ts
@noanflaherty
Copy link
Copy Markdown
Contributor Author

Addressed in #7518

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant