Skip to content

fix: use separate isSaving state and background task for video save#5058

Merged
siddseethepalli merged 1 commit into
mainfrom
swarm/task-11
Feb 19, 2026
Merged

fix: use separate isSaving state and background task for video save#5058
siddseethepalli merged 1 commit into
mainfrom
swarm/task-11

Conversation

@siddseethepalli
Copy link
Copy Markdown
Contributor

@siddseethepalli siddseethepalli commented Feb 19, 2026

Addresses review feedback from PR #5042:

  • Added separate isSaving state so save operation doesn't replace video player with loading spinner
  • Moved inline base64 decode + disk write to background Task to avoid main thread freeze
  • Save button shows disabled state during save instead of hiding the entire video player

Open with Devin

Co-Authored-By: Claude <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant