fix: lazy-load attachment safety (MIME filter, isLoading reset)#5053
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f416b9912b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| await MainActor.run { | ||
| isLoading = false | ||
| failed = true | ||
| } |
There was a problem hiding this comment.
Avoid marking playback failed on save I/O errors
This catch handles both fetch failures and data.write(to: destURL) failures, so setting failed = true here can switch the attachment into the “Could not play video” state even when playback is actually fine and only the save destination failed (for example, permission denied or disk full). That regresses the user flow by turning a save-specific error into a persistent playback failure.
Useful? React with 👍 / 👎.
|
The Codex feedback about save I/O errors setting |
Addresses review feedback from PR #5019: