Skip to content

fix: lazy-load attachment safety (MIME filter, isLoading reset)#5053

Merged
siddseethepalli merged 1 commit into
mainfrom
swarm/task-6
Feb 19, 2026
Merged

fix: lazy-load attachment safety (MIME filter, isLoading reset)#5053
siddseethepalli merged 1 commit into
mainfrom
swarm/task-6

Conversation

@siddseethepalli
Copy link
Copy Markdown
Contributor

@siddseethepalli siddseethepalli commented Feb 19, 2026

Addresses review feedback from PR #5019:


Open with Devin

Co-Authored-By: Claude <noreply@anthropic.com>
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f416b9912b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +201 to +204
await MainActor.run {
isLoading = false
failed = true
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid marking playback failed on save I/O errors

This catch handles both fetch failures and data.write(to: destURL) failures, so setting failed = true here can switch the attachment into the “Could not play video” state even when playback is actually fine and only the save destination failed (for example, permission denied or disk full). That regresses the user flow by turning a save-specific error into a persistent playback failure.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@siddseethepalli
Copy link
Copy Markdown
Contributor Author

The Codex feedback about save I/O errors setting failed = true was already addressed by PR #5058, which refactored the save flow to use a separate isSaving state. The catch block in saveVideo() no longer sets failed = true — save errors only reset isSaving, leaving playback state unaffected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant