Skip to content

fix(githooks): rename LINENO to avoid shadowing bash built-in #30587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
siddseethepalli merged 1 commit into from
May 13, 2026
Merged

fix(githooks): rename LINENO to avoid shadowing bash built-in #30587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .githooks/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -867,14 +867,16 @@ while IFS= read -r -d '' FILE; do
if [ -z "$line" ]; then
continue
fi
LINENO="${line%%:*}"
MATCH_LINENO="${line%%:*}"
CONTENT="${line#*:}"
# Context-aware patterns need the line that follows the match
# in the staged blob (e.g. to confirm a bare `clientSecret:` key
# sits in an OpenAPI schema). Compute lazily — only when needed.
# Note: do not use the name `LINENO` here — it shadows bash's
# built-in, which always reports the current script line.
NEXT_LINE=""
if [[ "$LINENO" =~ ^[0-9]+$ ]] && [[ "$FILE" =~ \.(yaml|yml)$ ]]; then
NEXT_LINE=$(git show ":$FILE" 2>/dev/null | sed -n "$((LINENO + 1))p")
if [[ "$MATCH_LINENO" =~ ^[0-9]+$ ]] && [[ "$FILE" =~ \.(yaml|yml)$ ]]; then
NEXT_LINE=$(git show ":$FILE" 2>/dev/null | sed -n "$((MATCH_LINENO + 1))p")
fi
if matches_safe_line_pattern "$CONTENT" "$FILE" "$NEXT_LINE"; then
# Strip safe-line portions and re-check: a real secret
Expand Down