fix(githooks): rename LINENO to avoid shadowing bash built-in#30587
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #30549. The variable
LINENOin pre-commit hook shadows bash's built-inLINENO, which always evaluates to the current script line number regardless of assignment. SoLINENO="${line%%:*}"had no lasting effect — when later referenced, bash returned the script's physical line (~877), not the grep match line.Result:
sed -n "$((LINENO + 1))p"fetched approximately line 878 of the staged file regardless of match position. For YAML files shorter than ~878 lines, NEXT_LINE was always empty, so the context guard always failed and bareclientSecret:was never whitelisted even in legitimate OpenAPI schemas.Renamed to
MATCH_LINENOand added an inline comment documenting why.Test plan
.githooks/pre-commit --self-testpasses