Skip to content

fix(macos): unbreak macOS tests after inferenceMode removal #30237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
siddseethepalli merged 1 commit into from
May 11, 2026
Merged

fix(macos): unbreak macOS tests after inferenceMode removal #30237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions clients/macos/vellum-assistantTests/Features/Settings/InferenceProfileEditorTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -788,24 +788,4 @@ final class InferenceProfileEditorTests: XCTestCase {
_ = editor.body
XCTAssertEqual(cancelCalls, 0)
}

// MARK: - Provider dropdown filtering

func testManagedModeShowsOnlyManagedCapableProviders() {
store.inferenceMode = "managed"
let (editor, _) = makeEditor(profile: InferenceProfile(name: "draft"))
XCTAssertEqual(
Set(editor.availableProviderIds),
Set(["anthropic", "openai", "gemini"])
)
XCTAssertFalse(editor.availableProviderIds.contains("openrouter"))
}

func testYourOwnModeShowsAllCatalogProviders() {
store.inferenceMode = "your-own"
let (editor, _) = makeEditor(profile: InferenceProfile(name: "draft"))
XCTAssertTrue(editor.availableProviderIds.contains("openrouter"),
"your-own mode should expose all catalog providers including openrouter")
XCTAssertEqual(editor.availableProviderIds.count, store.dynamicProviderIds.count)
}
}
2 changes: 1 addition & 1 deletion clients/macos/vellum-assistantTests/Network/ProviderConnectionClientTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ final class ProviderConnectionClientTests: XCTestCase {
func testListReturnsEmptyWhenClientReturnsEmpty() async {
mock.listResponse = []
let result = await mock.listProviderConnections(provider: nil)
XCTAssertEqual(result, [])
XCTAssertEqual(result?.count, 0)
XCTAssertEqual(mock.listCallCount, 1)
XCTAssertNil(mock.listProviderArg as Any? as? String)
}
Expand Down