fix(macos): unbreak macOS tests after inferenceMode removal#30237
Merged
Conversation
…sert PR #30231 removed `SettingsStore.inferenceMode` and the managed-only branch of `InferenceProfileEditor.availableProviderIds`, but two tests in `InferenceProfileEditorTests.swift` still referenced the deleted field. Delete them. `ProviderConnectionClientTests.testListReturnsEmptyWhenClientReturnsEmpty` called `XCTAssertEqual(result, [])`, but `ProviderConnection` is a generated Codable/Sendable struct without an `Equatable` conformance. Switch to `XCTAssertEqual(result?.count, 0)` to match the style used by the surrounding tests.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InferenceProfileEditorTestscases that referencedSettingsStore.inferenceMode, removed in feat(macos): inference providers UI (Phase 2 PR-E) #30231 along with the managed-only branch ofavailableProviderIds.XCTAssertEqual(result, [])inProviderConnectionClientTestswithXCTAssertEqual(result?.count, 0)— the generatedProviderConnectionstruct isCodable, Sendablebut notEquatable.Original prompt
Fix the macOS Tests CI job (run 25645467173) that broke on
mainafter #30231 landed. The build failed withvalue of type 'SettingsStore' has no member 'inferenceMode'atInferenceProfileEditorTests.swift:795,805andXCTAssertEqual ... requires that 'ProviderConnection' conform to 'Equatable'atProviderConnectionClientTests.swift:113. Scope this fix to those two failures only.