Skip to content

fix(macos): reset thinking anchor on multi-wave runs, flatten padding, fix Date() consistency #25936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asharma53 merged 1 commit into from
Apr 15, 2026
Merged

fix(macos): reset thinking anchor on multi-wave runs, flatten padding, fix Date() consistency #25936

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions clients/macos/vellum-assistant/Features/Chat/AssistantProgressView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,12 @@ struct AssistantProgressView: View {
startDate = Date()
}
}
// Reset thinking anchor when tools resume in a multi-wave run
// (tools complete → think → more tools → think → complete).
if newPhase == .toolRunning || newPhase == .streamingCode {
thinkingAfterToolsStartDate = nil
thinkingAfterToolsEndDate = nil
Comment thread
asharma53 marked this conversation as resolved.
}
// Track thinking phase start: all tools complete, card still active.
if (newPhase == .toolsCompleteThinking || newPhase == .processing)
&& model.allComplete && model.hasTools
Expand All @@ -298,10 +304,11 @@ struct AssistantProgressView: View {
}
// Track thinking phase end: card transitioned to complete.
if newPhase == .complete, let thinkingStart = thinkingAfterToolsStartDate, thinkingAfterToolsEndDate == nil {
thinkingAfterToolsEndDate = Date()
let now = Date()
thinkingAfterToolsEndDate = now
// Persist duration so it survives view recycling.
if let key = cardKey {
let duration = Date().timeIntervalSince(thinkingStart)
let duration = now.timeIntervalSince(thinkingStart)
progressUIState.setThinkingDuration(for: key, duration: duration)
}
}
Expand Down Expand Up @@ -1060,8 +1067,7 @@ private struct ThinkingStepRow: View {
}
}
}
.padding(EdgeInsets(top: VSpacing.xs, leading: VSpacing.sm, bottom: VSpacing.xs, trailing: VSpacing.xs))
.padding(EdgeInsets(top: 0, leading: VSpacing.sm, bottom: 0, trailing: VSpacing.xs))
.padding(EdgeInsets(top: VSpacing.xs, leading: VSpacing.sm + VSpacing.sm, bottom: VSpacing.xs, trailing: VSpacing.xs + VSpacing.xs))
}
}
}
Expand Down