fix(macos): reset thinking anchor on multi-wave runs, flatten padding, fix Date() consistency#25936
Merged
Conversation
…, fix Date() consistency Follow-up to #25884. Three fixes: 1. Reset thinkingAfterToolsStartDate/EndDate when tools resume so multi-wave runs don't inflate thinking duration. 2. Combine consecutive .padding() modifiers in ThinkingStepRow per macOS AGENTS.md rules. 3. Capture single Date() in handlePhaseChange completion path to avoid timestamp drift between displayed and persisted thinking duration. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 76391b7c6f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
Author
|
Addressed in #25963 |
Contributor
Author
|
Addressed in #25968 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
thinkingAfterToolsStartDate/EndDatewhen tools resume (.toolRunning/.streamingCode) so multi-wave runs don't inflate thinking duration.padding()modifiers inThinkingStepRowinto a single call per macOS AGENTS.md rules (perf hazard in LazyVStack)let now = Date()inhandlePhaseChangecompletion path to avoid timestamp drift between displayed and persisted thinking durationFollow-up to #25884.
Test plan
🤖 Generated with Claude Code