fix(personas): restrict persona-file seeding to guardians and invalidate trust cache on guardian creation#24878
Merged
Conversation
…ate trust cache on guardian creation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
siddseethepalli
added a commit
that referenced
this pull request
Apr 11, 2026
siddseethepalli
added a commit
that referenced
this pull request
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two post-plan fixes from the drop-user-md review:
Guardian-only seeding.
upsertContactChannelpreviously calledensureGuardianPersonaFileon every new contact (Slack, phone, email, etc), which fired theusers/directory watcher and evicted live conversations on every inbound message from a new contact. Restrict seeding to guardian creation only.Trust-cache invalidation. The guardian-persona auto-allow rule from the permissions defaults is only backfilled during
trust-store.loadFromDisk(). Runtime guardian creation paths (self-heal, first-message-seeds-guardian) did not invalidate the cache, so the rule was never backfilled for those guardians and the model had to approve its firstfile_editonusers/<slug>.md. CallclearTrustCache()after guardian creation.Also rename
ensureGuardianPersonaFile(slug)toensureGuardianPersonaFile(userFile)for parameter clarity — the argument is a full filename, not a bare slug.Fixes gaps identified during drop-user-md plan review.