fix: use client host env in workspace block for managed daemons#24420
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Addresses Codex review feedback: when a conversation is reused across interfaces (macOS → iOS/CLI/channels), previously-stored macOS host env values were sticking around and leaking stale Mac paths into the <workspace> block on later non-macOS turns. Clear hostHomeDir and hostUsername when transport is non-macOS so the renderer falls back to the daemon's own os.homedir() / os.userInfo().username. Mirror the fix in both applyTransportMetadata and the queue-drain path.
Contributor
Author
Contributor
Author
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<workspace>block renderer was callingos.homedir()/os.userInfo().usernamedirectly, which returns the container's values for platform-managed (hosted) daemons. ThehostHomeDir/hostUsernamefields plumbed throughMacosTransportMetadataby fix: pass transport hints through HTTP message endpoint for managed-mode conversations #23824 were stored but never read, so managed assistants saw the container home dir and hallucinated user-facing paths like/Users/marina/Desktop/test.txtfrom the user's display name.ConversationfromapplyTransportMetadata(and the queue-drain path), expose it viaWorkspaceConversationContext, and haverenderWorkspaceTopLevelContextprefer those values withos.homedir()/os.userInfo().usernameas a fallback for non-macOS / server-initiated paths.Original prompt
it