fix: pass transport hints through HTTP message endpoint for managed-mode conversations by noanflaherty · Pull Request #23824 · vellum-ai/vellum-assistant

noanflaherty · 2026-04-06T20:54:32Z

Summary

The POST /v1/messages handler auto-creates conversations without passing transport metadata, so applyTransportMetadata() returns early and host environment hints (hostHomeDir, hostUsername) are never injected into the LLM context. This causes the assistant to hallucinate the user's home directory path from their display name (e.g. /Users/Marina/) instead of using the actual macOS username (/Users/vellumaihq/).
Thread transport metadata from the HTTP message request body through SendMessageDeps.getOrCreateConversation() → getConversationForMessages() → getOrCreateConversation() → applyTransportMetadata(), and include hostHomeDir/hostUsername from the macOS client in every message request.
This closes the gap where transport hints worked for daemon-to-daemon conversations (WebSocket ConversationCreateRequest) but not for HTTP-mode conversations used by managed-mode macOS clients.

Original prompt

Fix the transport hints not being injected for managed-mode conversations created via POST /v1/messages.

… environment hints The HTTP message handler auto-creates conversations without transport metadata, so applyTransportMetadata() returns early and host environment hints (hostHomeDir, hostUsername) are never injected into the LLM context. This causes the assistant to hallucinate the user's home directory path from their display name instead of using the actual macOS username. Thread transport metadata from the message request body through SendMessageDeps.getOrCreateConversation() to the daemon, and send hostHomeDir/hostUsername from the macOS client in every message request. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

noanflaherty · 2026-04-06T20:59:40Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 620e892b7a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-06T21:06:19Z

  const conversation = await smDeps.getOrCreateConversation(
    mapping.conversationId,
+    { transport },


Avoid mutating transport hints before busy-state queue check

This call now passes { transport } before we know whether the conversation is already processing. DaemonServer.getOrCreateConversation() applies that metadata immediately, so a second POST /v1/messages that gets queued can still overwrite conversation.transportHints on the live conversation. Because the active agent loop reads ctx.transportHints from this mutable state when building injections, the in-flight turn can pick up the queued request’s host/home hints (including spoofed values) and respond with incorrect environment guidance. Transport metadata should be applied only when the message becomes active (or stored on the queued item and applied at dequeue).

Useful? React with 👍 / 👎.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…ode conversations (#23824) * fix: pass transport metadata through POST /v1/messages to enable host environment hints The HTTP message handler auto-creates conversations without transport metadata, so applyTransportMetadata() returns early and host environment hints (hostHomeDir, hostUsername) are never injected into the LLM context. This causes the assistant to hallucinate the user's home directory path from their display name instead of using the actual macOS username. Thread transport metadata from the message request body through SendMessageDeps.getOrCreateConversation() to the daemon, and send hostHomeDir/hostUsername from the macOS client in every message request. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * refactor: replace dynamic imports with static type imports Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* revert: disable Teleport feature flag by default (#23744) (#23815) * fix: replace auxWhite-on-primaryBase with VButton across the app (#23802) * fix: use VButton for inline surface action buttons Replace raw Button with manual color functions in InlineSurfaceRouter with the design system VButton component. The manual buttonForeground used VColor.auxWhite (always #FFFFFF) against VColor.primaryBase which resolves to #FDFDFC in dark mode, producing invisible white-on-white text. Closes LUM-730 Co-Authored-By: ashlee@vellum.ai <ashlee@vellum.ai> * fix: replace auxWhite-on-primaryBase with VButton in additional locations FileUploadSurfaceView: Upload/Cancel buttons used raw Button with VColor.auxWhite on VColor.primaryBase — white-on-white in dark mode. Replaced with VButton(.primary) and VButton(.outlined). JITPermissionView: Permission buttons used the same auxWhite pattern. Replaced with VButton(.primary/.outlined, isFullWidth: true). ImproveExperienceStepView: ToS checkbox checkmark used auxWhite on primaryBase fill. Changed to VColor.contentInset which adapts per color scheme. ChatGallerySection: Gallery demo of surface action pills mirrored the old buggy pattern. Updated to use VButton so the gallery accurately represents production rendering. Co-Authored-By: ashlee@vellum.ai <ashlee@vellum.ai> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: ashlee@vellum.ai <ashlee@vellum.ai> * Make dictation engine start non-blocking with audio route resilience (#23811) * Make dictation engine start non-blocking and improve audio resilience - Add installTapAndStartAsync to AudioEngineController for non-blocking engine start using Swift concurrency (withCheckedContinuation) - Extract installTapAndStartImpl to share logic between sync/async paths - Listen for AVAudioEngineConfigurationChange to re-prewarm inputNode after Bluetooth device connect/disconnect and AirPods mode switches - Restructure VoiceInputManager.beginRecording() to show recording UI and play activation chime immediately, then start engine async via Task - Move DictationContextCapture off the critical path: engine starts concurrently on its audio queue while context capture runs on main - Add SFSpeechRecognizer transient unavailability retry (recreate if isAvailable returns false after sleep/wake or heavy use) - Handle edge case where PTT is released before async engine start completes (stopRecordingForDictation cleans up directly) Co-Authored-By: tkheyfets <timur@vellum.ai> * Tear down engine when async startup outlives recording session When PTT is released before installTapAndStartAsync completes, the isRecording guard now stops and removes the tap if the engine started successfully, preventing the mic path from staying alive with no active recording session. Co-Authored-By: tkheyfets <timur@vellum.ai> * Add recording generation token and gate context capture on start success Co-Authored-By: tkheyfets <timur@vellum.ai> * Guard stale teardown against active sessions and gate rewarm on mic auth Co-Authored-By: tkheyfets <timur@vellum.ai> * Move context capture to Task.detached to avoid blocking main actor Co-Authored-By: tkheyfets <timur@vellum.ai> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: tkheyfets <timur@vellum.ai> * [LUM-681] Fix audio tap format mismatch by resetting engine before installTap (#23766) After audio-route changes (Bluetooth, USB mic, AirPods mode switch), the format cached inside AVAudioInputNode diverges from the engine's actual hardware format. Both outputFormat(forBus:) and a nil format argument to installTap resolve to this stale value, causing: 'Failed to create tap due to format mismatch, <AVAudioFormat: 2 ch, 44100 Hz, Float32, deinterleaved>' Fix: call audioEngine.reset() before re-querying the format, then pass it explicitly to installTap. This forces the engine to discard its cached graph state and re-read the hardware, so the tap, node, and engine all agree. Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: tkheyfets <timur@vellum.ai> * fix: pass transport hints through HTTP message endpoint for managed-mode conversations (#23824) * fix: pass transport metadata through POST /v1/messages to enable host environment hints The HTTP message handler auto-creates conversations without transport metadata, so applyTransportMetadata() returns early and host environment hints (hostHomeDir, hostUsername) are never injected into the LLM context. This causes the assistant to hallucinate the user's home directory path from their display name instead of using the actual macOS username. Thread transport metadata from the message request body through SendMessageDeps.getOrCreateConversation() to the daemon, and send hostHomeDir/hostUsername from the macOS client in every message request. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * refactor: replace dynamic imports with static type imports Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: ashlee@vellum.ai <ashlee@vellum.ai> Co-authored-by: tkheyfets <timur@vellum.ai> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Release v0.6.1 * Cherry-pick fixes for v0.6.1 (#23785) * Increase teleport import timeout from 2 to 5 minutes (#23749) * increase teleport import timeout from 2 to 5 minutes * fix: update platform import timeout error message to say 5 minutes Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Update billing tab copy: referral subtitle, remove earning cap note, move credit info to card subtitle (#23751) * fix(macos): always collapse thinking blocks by default (#23750) Thinking blocks were auto-expanding during streaming, showing a wall of text. Remove the auto-expand logic so blocks always start collapsed. Users can still manually expand them. The header already shows "Thinking..." vs "Thought process" as a streaming indicator. Closes LUM-729 Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: ashlee@vellum.ai <ashlee@vellum.ai> * [LUM-684/LUM-726] Fix dictation crash: pass nil format to installTap (#23754) * Fix dictation crash: pass nil format to installTap, consolidate audio engine calls Pass nil for the format parameter in AVAudioNode.installTap(onBus:bufferSize:format:block:) so AVAudioEngine uses its own internal hardware format, which is always self-consistent. This prevents NSInternalInconsistencyException crashes caused by format.sampleRate != hwFormat.sampleRate when the cached format from outputFormat(forBus:) diverges from the engine's internal hardware format after audio route changes (Bluetooth, USB mic, AirPods mode switch). AudioEngineController.swift: - installTapAndStart() now passes nil instead of explicit format to installTap - Removed 6 now-unused methods: inputNodeFormat(), installTap(bufferSize:format:block:), removeTap(), prepare(), start(), prepareAndStart() OpenAIVoiceService.swift: - startRecording(): replaced separate inputNodeFormat/installTap/prepare/start chain with single installTapAndStart() call - startBargeInMonitor(): same migration to installTapAndStart() - Removed error-path removeTap() call (handled internally by installTapAndStart) Resolves: LUM-684, LUM-726 Co-Authored-By: tkheyfets <timur@vellum.ai> * fix: use explicit block: parameter in guard statements for installTapAndStart Swift doesn't support trailing closure syntax with guard statements, causing compilation errors. Use explicit block: parameter label instead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: tkheyfets <timur@vellum.ai> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: replace contrast buttons with primary style (#23753) Remove all production usages of .contrast button style in favor of .primary. Fixes white-on-white button visibility issues in chat composer. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Inject host environment via transport hints (#23779) * refactor: discriminated union for transport metadata, remove iOS proxy setup (#23776) * feat: inject interface ID and macOS host environment into transport hints (#23777) * feat: send hostHomeDir and hostUsername from macOS client (#23778) * fix: remove iOS from proxy restoration in conversation-process.ts (#23782) --------- Co-authored-by: Carson Shaar <carson.s.shaar@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: ashlee@vellum.ai <ashlee@vellum.ai> Co-authored-by: tkheyfets <timur@vellum.ai> Co-authored-by: Tirman Sidhu <tirmansidhu@gmail.com> * [skip ci] Cherry-pick fixes for v0.6.1 (#23820) * revert: disable Teleport feature flag by default (#23744) (#23815) * fix: replace auxWhite-on-primaryBase with VButton across the app (#23802) * fix: use VButton for inline surface action buttons Replace raw Button with manual color functions in InlineSurfaceRouter with the design system VButton component. The manual buttonForeground used VColor.auxWhite (always #FFFFFF) against VColor.primaryBase which resolves to #FDFDFC in dark mode, producing invisible white-on-white text. Closes LUM-730 Co-Authored-By: ashlee@vellum.ai <ashlee@vellum.ai> * fix: replace auxWhite-on-primaryBase with VButton in additional locations FileUploadSurfaceView: Upload/Cancel buttons used raw Button with VColor.auxWhite on VColor.primaryBase — white-on-white in dark mode. Replaced with VButton(.primary) and VButton(.outlined). JITPermissionView: Permission buttons used the same auxWhite pattern. Replaced with VButton(.primary/.outlined, isFullWidth: true). ImproveExperienceStepView: ToS checkbox checkmark used auxWhite on primaryBase fill. Changed to VColor.contentInset which adapts per color scheme. ChatGallerySection: Gallery demo of surface action pills mirrored the old buggy pattern. Updated to use VButton so the gallery accurately represents production rendering. Co-Authored-By: ashlee@vellum.ai <ashlee@vellum.ai> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: ashlee@vellum.ai <ashlee@vellum.ai> * Make dictation engine start non-blocking with audio route resilience (#23811) * Make dictation engine start non-blocking and improve audio resilience - Add installTapAndStartAsync to AudioEngineController for non-blocking engine start using Swift concurrency (withCheckedContinuation) - Extract installTapAndStartImpl to share logic between sync/async paths - Listen for AVAudioEngineConfigurationChange to re-prewarm inputNode after Bluetooth device connect/disconnect and AirPods mode switches - Restructure VoiceInputManager.beginRecording() to show recording UI and play activation chime immediately, then start engine async via Task - Move DictationContextCapture off the critical path: engine starts concurrently on its audio queue while context capture runs on main - Add SFSpeechRecognizer transient unavailability retry (recreate if isAvailable returns false after sleep/wake or heavy use) - Handle edge case where PTT is released before async engine start completes (stopRecordingForDictation cleans up directly) Co-Authored-By: tkheyfets <timur@vellum.ai> * Tear down engine when async startup outlives recording session When PTT is released before installTapAndStartAsync completes, the isRecording guard now stops and removes the tap if the engine started successfully, preventing the mic path from staying alive with no active recording session. Co-Authored-By: tkheyfets <timur@vellum.ai> * Add recording generation token and gate context capture on start success Co-Authored-By: tkheyfets <timur@vellum.ai> * Guard stale teardown against active sessions and gate rewarm on mic auth Co-Authored-By: tkheyfets <timur@vellum.ai> * Move context capture to Task.detached to avoid blocking main actor Co-Authored-By: tkheyfets <timur@vellum.ai> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: tkheyfets <timur@vellum.ai> * [LUM-681] Fix audio tap format mismatch by resetting engine before installTap (#23766) After audio-route changes (Bluetooth, USB mic, AirPods mode switch), the format cached inside AVAudioInputNode diverges from the engine's actual hardware format. Both outputFormat(forBus:) and a nil format argument to installTap resolve to this stale value, causing: 'Failed to create tap due to format mismatch, <AVAudioFormat: 2 ch, 44100 Hz, Float32, deinterleaved>' Fix: call audioEngine.reset() before re-querying the format, then pass it explicitly to installTap. This forces the engine to discard its cached graph state and re-read the hardware, so the tap, node, and engine all agree. Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: tkheyfets <timur@vellum.ai> * fix: pass transport hints through HTTP message endpoint for managed-mode conversations (#23824) * fix: pass transport metadata through POST /v1/messages to enable host environment hints The HTTP message handler auto-creates conversations without transport metadata, so applyTransportMetadata() returns early and host environment hints (hostHomeDir, hostUsername) are never injected into the LLM context. This causes the assistant to hallucinate the user's home directory path from their display name instead of using the actual macOS username. Thread transport metadata from the message request body through SendMessageDeps.getOrCreateConversation() to the daemon, and send hostHomeDir/hostUsername from the macOS client in every message request. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * refactor: replace dynamic imports with static type imports Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: ashlee@vellum.ai <ashlee@vellum.ai> Co-authored-by: tkheyfets <timur@vellum.ai> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * chore: reset non-version-bump files to match main Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Noa Flaherty <noa@vellum.ai> Co-authored-by: Carson Shaar <carson.s.shaar@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: ashlee@vellum.ai <ashlee@vellum.ai> Co-authored-by: tkheyfets <timur@vellum.ai> Co-authored-by: Tirman Sidhu <tirmansidhu@gmail.com> Co-authored-by: David Vargas Fuertes <vargasvellum@Davids-MacBook-Pro.local>

chatgpt-codex-connector Bot reviewed Apr 6, 2026

View reviewed changes

refactor: replace dynamic imports with static type imports

680fa81

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

noanflaherty merged commit 1831b88 into main Apr 6, 2026
12 checks passed

noanflaherty deleted the do/fix-http-transport-hints branch April 6, 2026 21:09

noanflaherty mentioned this pull request Apr 8, 2026

fix: use client host env in workspace block for managed daemons #24420

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: pass transport hints through HTTP message endpoint for managed-mode conversations#23824

fix: pass transport hints through HTTP message endpoint for managed-mode conversations#23824
noanflaherty merged 2 commits into
mainfrom
do/fix-http-transport-hints

noanflaherty commented Apr 6, 2026 •

edited by devin-ai-integration Bot

Loading

Uh oh!

noanflaherty commented Apr 6, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Apr 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

noanflaherty commented Apr 6, 2026 • edited by devin-ai-integration Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Original prompt

Uh oh!

noanflaherty commented Apr 6, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

noanflaherty commented Apr 6, 2026 •

edited by devin-ai-integration Bot

Loading