Skip to content

Don't mark history loaded when skipping late history_response #1903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
siddseethepalli merged 1 commit into from
Feb 14, 2026
Merged

Don't mark history loaded when skipping late history_response #1903

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion clients/macos/vellum-assistant/Features/Chat/ChatViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1017,7 +1017,10 @@ final class ChatViewModel: ObservableObject {
func populateFromHistory(_ historyMessages: [HistoryResponseMessage.HistoryMessageItem]) {
let hasUserSentMessages = messages.contains { $0.role == .user }
if hasUserSentMessages {
isHistoryLoaded = true
// Don't set isHistoryLoaded here — the user sent a message before
// history arrived, so we skipped populating. Leaving the flag false
// allows ThreadManager.loadHistoryForActiveThreadIfNeeded() to
// retry on the next tab switch.
return
Comment thread
siddseethepalli marked this conversation as resolved.
Comment thread
siddseethepalli marked this conversation as resolved.
}

Expand Down