Don't mark history loaded when skipping late history_response#1903
Merged
Conversation
When a user sends a message before history_response arrives, populateFromHistory() returned early but still set isHistoryLoaded = true. This prevented ThreadManager.loadHistoryForActiveThreadIfNeeded() from ever retrying, permanently losing prior messages in the UI for that thread. Leave isHistoryLoaded = false on the early-return path so the next tab switch can re-request history. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 82b244b42b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
siddseethepalli
added a commit
that referenced
this pull request
Feb 14, 2026
When a history_response arrives after the user has already sent messages, prepend the history messages before the existing ones instead of returning early with isHistoryLoaded=false. This gives the user full conversation context while preventing the infinite retry cycle flagged in PR #1903. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
siddseethepalli
added a commit
that referenced
this pull request
Feb 14, 2026
…1909) When a history_response arrives after the user has already sent messages, prepend the history messages before the existing ones instead of returning early with isHistoryLoaded=false. This gives the user full conversation context while preventing the infinite retry cycle flagged in PR #1903. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
Addressed in #1909 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a user sends a message before
history_responsearrives,populateFromHistory()returned early but still setisHistoryLoaded = true. This preventedThreadManager.loadHistoryForActiveThreadIfNeeded()from ever retrying (due toguard !viewModel.isHistoryLoaded), permanently losing prior messages in the UI for that restored thread.Fix
Leave
isHistoryLoaded = falseon the early-return path so that the next tab switch triggers a fresh history request.Addresses review feedback on #1853.