Extract design system to shared library with iOS compatibility#1868
Conversation
Move the entire DesignSystem directory from clients/macos/vellum-assistant/ to clients/shared/ to enable code reuse between macOS and iOS targets. Changes: - Moved all design system files (Tokens, Core, Components, Modifiers, Gallery) to clients/shared/DesignSystem/ - Made all public types, properties, and methods explicitly public for cross-module access - Added conditional compilation for platform-specific code: - TypographyTokens: Platform-specific font descriptor handling (NSFont vs UIFont) - Buttons: macOS-only cursor hover effects (#if os(macOS)) - VToast: Platform-specific accessibility (NSAccessibility vs UIAccessibility) - Made Color hex initializer public - Made all color scale enums public (Slate, Emerald, Violet, Indigo, Rose, Amber) - Made all semantic color tokens public (VColor) - Made all spacing, radius, animation, shadow tokens public - Made ComponentGalleryWindow public with public init and show method - Updated 40+ macOS files to import VellumAssistantShared Part of iOS rollout plan (PR 2 of 13) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e53539e8e1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| #if DEBUG | ||
| import AppKit |
There was a problem hiding this comment.
Because this file now lives in VellumAssistantShared, #if DEBUG is true for iOS debug builds too, so import AppKit and the NSWindow APIs in show() are compiled when targeting iOS and fail immediately. This blocks debug iOS builds of the shared module even though the change is intended to add iOS compatibility; gate this file with #if os(macOS) && DEBUG (or equivalent) so iOS targets can compile.
Useful? React with 👍 / 👎.
- ComponentGalleryWindow: Add os(macOS) guard to #if DEBUG to prevent iOS compilation failure - VToast: Restore style prefix and priority in NSAccessibility announcement for VoiceOver users Fixes identified by Devin and Codex review bots. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
Fixed review feedback in 9b9c8fc:
Both issues identified by Devin and Codex have been resolved. |
iOS VoiceOver users now hear severity context (e.g., "error: Something went wrong") matching the macOS experience. Previously iOS only announced the bare message without the style prefix. Addresses Devin review feedback. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
Fixed iOS accessibility in 54c4a92: VToast.swift - Added style prefix to iOS VoiceOver announcement to match macOS behavior. iOS users now hear "error: Something went wrong" instead of just "Something went wrong", providing severity context. |
- Remove redundant `import VellumAssistantShared` from gallery files (cosmetic) - Add UIFontDescriptor implementation for Stylistic Set 5 on iOS for visual parity with macOS - Add explicit public init() to HoverEffectModifier and PanelBackgroundModifier for cross-module instantiation Addresses user review feedback. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
Addressed all user review feedback in fec7e37: ✅ All issues fixed:
All builds passing, ready for approval! 🎉 |
All other methods (init, show) are public, so close() should be too. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
Fixed minor nit in be1a4d0: Made |
Use correct iOS property names: - .featureIdentifier (for feature type, not .type) - .typeIdentifier (for feature selector, not .selector) The iOS naming is confusing because .typeIdentifier on iOS corresponds to .selectorIdentifier on macOS. This fix prevents iOS compilation failure. Addresses Devin review feedback. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
Fixed critical iOS compilation issue in 4672e22: UIFontDescriptor property names corrected:
The confusing naming asymmetry between macOS and iOS:
This would have prevented iOS compilation when targeting the shared library. Thanks Devin for catching this! |
Add #else clause to handle unsupported platforms (visionOS, tvOS, watchOS). Without this, the function would have no return statement on those platforms, causing a compilation error. Fallback uses plain Font.custom() without stylistic alternates. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
Addressed user review feedback in e1381a5: ✅ Fixed:#1 - Missing platform fallback in dmMono() - Added 📝 Acknowledged (non-blocking):#2 - Font resources not bundled in shared target - Will be addressed in PR 4 when iOS app target is created All critical issues resolved! 🎉 |
ashleeradka
deleted the
safe-plan/sharded-mapping-shannon/shared-design-system
branch
Remove 4 unused files (~297 lines) from clients/shared/: - NetworkInterfaceResolver.swift (58 lines) — zero references outside file. Added in PR #6656 (QR code pairing) but never used. - HoverEffect.swift (41 lines) — zero references outside file. Added in PR #1868 (Extract design system) but never used. - InlineWidgetCardModifier.swift (114 lines) — zero references outside file. Last touched in PR #3473 (platform guard fix). - VWaveformView.swift (84 lines) — zero references outside file. Added in PR #6095 (two-way voice mode) but never used. Co-Authored-By: ashlee@vellum.ai <ashlee@vellum.ai>
* chore: remove dead shared library files Remove 4 unused files (~297 lines) from clients/shared/: - NetworkInterfaceResolver.swift (58 lines) — zero references outside file. Added in PR #6656 (QR code pairing) but never used. - HoverEffect.swift (41 lines) — zero references outside file. Added in PR #1868 (Extract design system) but never used. - InlineWidgetCardModifier.swift (114 lines) — zero references outside file. Last touched in PR #3473 (platform guard fix). - VWaveformView.swift (84 lines) — zero references outside file. Added in PR #6095 (two-way voice mode) but never used. Co-Authored-By: ashlee@vellum.ai <ashlee@vellum.ai> * fix: restore InlineWidgetCardModifier and HoverEffect — actively used InlineWidgetCardModifier is used by ConfirmationSurfaceView.swift:48 (.inlineWidgetCard() call). HoverEffect is used by ModifiersGallerySection.swift:86 (.vHover() call in DEBUG gallery). Only NetworkInterfaceResolver and VWaveformView are confirmed dead in this PR. Co-Authored-By: ashlee@vellum.ai <ashlee@vellum.ai> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: ashlee@vellum.ai <ashlee@vellum.ai>
1 participant
Summary
Moved the entire DesignSystem directory from the macOS target to the shared library (
clients/shared/) to enable code reuse between macOS and iOS apps.Key Changes
Design System Structure:
clients/macos/vellum-assistant/DesignSystem/→clients/shared/DesignSystem/Conditional Compilation:
#if os(macOS)/#elseif os(iOS))Public API:
macOS Integration:
import VellumAssistantSharedto 40+ macOS filesTest Plan
Part of iOS rollout plan (PR 2 of 13):
sharded-mapping-shannon.md🤖 Generated with Claude Code