chore: remove dead shared library files#11767
Conversation
Remove 4 unused files (~297 lines) from clients/shared/: - NetworkInterfaceResolver.swift (58 lines) — zero references outside file. Added in PR #6656 (QR code pairing) but never used. - HoverEffect.swift (41 lines) — zero references outside file. Added in PR #1868 (Extract design system) but never used. - InlineWidgetCardModifier.swift (114 lines) — zero references outside file. Last touched in PR #3473 (platform guard fix). - VWaveformView.swift (84 lines) — zero references outside file. Added in PR #6095 (two-way voice mode) but never used. Co-Authored-By: ashlee@vellum.ai <ashlee@vellum.ai>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cb038569ab
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Requesting review from @ashleeradka (authored NetworkInterfaceResolver, HoverEffect) and @AnitaKirkovska (authored InlineWidgetCardModifier, VWaveformView). |
InlineWidgetCardModifier is used by ConfirmationSurfaceView.swift:48 (.inlineWidgetCard() call). HoverEffect is used by ModifiersGallerySection.swift:86 (.vHover() call in DEBUG gallery). Only NetworkInterfaceResolver and VWaveformView are confirmed dead in this PR. Co-Authored-By: ashlee@vellum.ai <ashlee@vellum.ai>
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
1 participant
Summary
Deletes 2 unused files (~142 lines) from
clients/shared/identified during a dead-code audit:NetworkInterfaceResolver.swiftVWaveformView.swiftAll types and their public methods were confirmed unreferenced via exhaustive
rgsearches acrossclients/.Updates since last revision
Restored
HoverEffect.swiftandInlineWidgetCardModifier.swiftafter review caught active usages:.inlineWidgetCard()is called byConfirmationSurfaceView.swift:48.vHover()is called byModifiersGallerySection.swift:86(DEBUG gallery)Review & Testing Checklist for Human
.swiftfiles — it does not update.pbxproj. If these files are registered in Xcode's build sources, the build will break. (If the shared lib uses SPM with automatic source discovery, this is a non-issue.)NetworkInterfaceResolverandgetLocalIPv4in non-Swift files (scripts, plists, Obj-C bridging headers) that therg --glob '*.swift'search would not have covered.VWaveformViewacross the full repo to confirm no references were missed — the initial scan already had two false positives in this PR, so extra caution is warranted.Notes
NetworkInterfaceResolverwas originally authored by @ashleeradkaVWaveformViewwas authored by @AnitaKirkovska