feat: support pre-binned timeUnit #8971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanitw
force-pushed
the
kw/8969-binned-timeunit
branch
from
a90d830
to
e201a97
Compare
kanitw
changed the title
kanitw
force-pushed
the
kw/8969-binned-timeunit
branch
3 times, most recently
from
4e318f5
to
aa264b4
Compare
Extracting since we'll later use this for other calculation too
kanitw
force-pushed
the
kw/8969-binned-timeunit
branch
2 times, most recently
from
f4c4c59
to
fd898bb
Compare
kanitw
force-pushed
the
kw/8969-binned-timeunit
branch
from
499a82d
to
9c018f3
Compare
kanitw
force-pushed
the
kw/8969-binned-timeunit
branch
from
9c018f3
to
b9efade
Compare
yhoonkim
approved these changes
Jun 29, 2023
site/docs/transform/timeunit.md
Outdated
| By default, all time units represent date time using local time. To use UTC time, you can add the `utc` prefix (e.g., `"utcyear"`, `"utcyearmonth"`). | ||
| - By default, all time units represent date time using local time. | ||
| - To use UTC time, you can add the `utc` prefix (e.g., `"utcyear"`, `"utcyearmonth"`). | ||
| - For timeUnit in encoding, you can also add `"binned"` prefix (e.g., `"binnedyearmonth"` or `"binnedutcyearmonth"`) for Chronological time unit (i.e., units that are truncated date time) |
There was a problem hiding this comment.
Not sure what Chronological time unit means here. Can we just say truncated (or binned) date time directly?
There was a problem hiding this comment.
It's another semantic-based way to explain date trunc (which focus on action being done on the date object, rather than the semantics).
It's a term that Jeff uses in Vega doc. https://vega.github.io/vega/docs/transforms/timeunit/
I added a bit more explanation so I hope it makes more sense now.
BradyJ27
pushed a commit
to BradyJ27/vega-lite
that referenced
this pull request
Oct 19, 2023
Co-authored-by: GitHub Actions Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8969
This allows us to use timeUnit without adding unnecessary timeUnit to re-bin the data, if the data has already been binned.