Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support prebinned time Unit params (so we can support steps too). #8972

Open
kanitw opened this issue Jun 27, 2023 · 0 comments
Open

Support prebinned time Unit params (so we can support steps too). #8972

kanitw opened this issue Jun 27, 2023 · 0 comments
Labels
Enhancement 🎉

Comments

@kanitw
Copy link
Member

kanitw commented Jun 27, 2023

Follow up of #8969's fix in #8971

In #8971, we only initially support binned timeUnit, which means we can't specify step yet.
kanitw added a commit that referenced this issue Jun 28, 2023
@kanitw
fix: support binned in TimeUnitParams (fix #8972)
aa264b4 
fix #8972

- rename old TimeUnitParams -> TimeUnitTransformParams
- rename TimeUnitParams ->
kanitw added a commit that referenced this issue Jun 28, 2023
@kanitw
fix: support binned in TimeUnitParams (fix #8972)
9dfef60 
fix #8972

- rename old TimeUnitParams -> TimeUnitTransformParams
- rename TimeUnitParams ->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement 🎉
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kanitw