Skip to content

chore: Bump vega-embed==7 #3829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattijn merged 3 commits into from
Apr 22, 2025
Merged

chore: Bump vega-embed==7 #3829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0730eb1
bumped vega embed version
franzhaas Apr 21, 2025
270fb61
- bumped at referenced places
franzhaas Apr 21, 2025
601fff9
- more
franzhaas Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion altair/jupyter/js/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import vegaEmbed from "https://esm.sh/vega-embed@6?deps=vega@5&deps=vega-lite@5.21.0";
import vegaEmbed from "https://esm.sh/vega-embed@7?deps=vega@5&deps=vega-lite@5.21.0";
import lodashDebounce from "https://esm.sh/lodash-es@4.17.21/debounce";

// Note: For offline support, the import lines above are removed and the remaining script
Expand Down
2 changes: 1 addition & 1 deletion altair/utils/schemapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1689,7 +1689,7 @@ def with_property_setters(cls: type[TSchemaBase]) -> type[TSchemaBase]:
str,
] = {
"vega-datasets": "v2.11.0",
"vega-embed": "6",
"vega-embed": "7",
"vega-lite": "v5.21.0",
"vegafusion": "1.6.6",
"vl-convert-python": "1.7.0",
Expand Down
2 changes: 1 addition & 1 deletion altair/vegalite/v5/display.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

VEGALITE_VERSION: Final = SCHEMA_VERSION.lstrip("v")
VEGA_VERSION: Final = "5"
VEGAEMBED_VERSION: Final = "6"
VEGAEMBED_VERSION: Final = "7"


# ==============================================================================
Expand Down
2 changes: 1 addition & 1 deletion doc/_static/chart.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<head>
<script src="https://cdn.jsdelivr.net/npm/vega@5"></script>
<script src="https://cdn.jsdelivr.net/npm/vega-lite@5"></script>
<script src="https://cdn.jsdelivr.net/npm/vega-embed@6"></script>
<script src="https://cdn.jsdelivr.net/npm/vega-embed@7"></script>
</head>
<body>
<div id="vis"></div>
Expand Down
2 changes: 1 addition & 1 deletion doc/conf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,4 +370,4 @@ def setup(app):
# Defaults for below are drawn from Altair; override here.
# altairplot_vega_js_url = "https://cdn.jsdelivr.net/npm/vega@5"
# altairplot_vegalite_js_url = "https://cdn.jsdelivr.net/npm/vega-lite@4"
# altairplot_vegaembed_js_url = "https://cdn.jsdelivr.net/npm/vega-embed@6"
# altairplot_vegaembed_js_url = "https://cdn.jsdelivr.net/npm/vega-embed@7"
2 changes: 1 addition & 1 deletion doc/user_guide/saving_charts.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ javascript-enabled web browser:
<head>
<script src="https://cdn.jsdelivr.net/npm/vega@5"></script>
<script src="https://cdn.jsdelivr.net/npm/vega-lite@5"></script>
<script src="https://cdn.jsdelivr.net/npm/vega-embed@6"></script>
<script src="https://cdn.jsdelivr.net/npm/vega-embed@7"></script>
</head>
<body>
<div id="vis"></div>
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ doc = [
[tool.altair.vega]
# Minimum/exact versions, for projects under the `vega` organization
vega-datasets = "v2.11.0" # https://github.com/vega/vega-datasets
vega-embed = "6" # https://github.com/vega/vega-embed
vega-embed = "7" # https://github.com/vega/vega-embed
vega-lite = "v5.21.0" # https://github.com/vega/vega-lite

[tool.hatch]
Expand Down
2 changes: 1 addition & 1 deletion tests/vegalite/v5/test_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -888,7 +888,7 @@ def test_save_html(basic_chart, inline):
else:
assert 'src="https://cdn.jsdelivr.net/npm/vega@5' in content
assert 'src="https://cdn.jsdelivr.net/npm/vega-lite@5' in content
assert 'src="https://cdn.jsdelivr.net/npm/vega-embed@6' in content
assert 'src="https://cdn.jsdelivr.net/npm/vega-embed@7' in content


@skip_requires_vl_convert
Expand Down
2 changes: 1 addition & 1 deletion tools/versioning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

>>> VERSIONS # doctest: +SKIP
{'vega-datasets': 'v2.11.0',
'vega-embed': '6',
'vega-embed': '7',
'vega-lite': 'v5.20.1',
'vegafusion': '1.5.0',
'vl-convert-python': '1.7.0'}
Expand Down