Conversation
Contributor
Author
|
as discussed here.: #3828 |
Contributor
|
Thanks for this PR, it looks great. You had to bump the version at a few places I see. Something we should be aware of when updating to vegalite 6. Thanks again! |
Contributor
Author
|
Thanks! |
Contributor
Author
If you want I can provide a PR for that as well... |
Contributor
|
It is a bit more work, but if you are able to, that would be great😊, there are docs here, https://github.com/vega/altair/blob/main/NOTES_FOR_MAINTAINERS.md, that describe this process, but please report anything that is unclear in the process, which can be used to improve the notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Altair! 🎉
Please follow these guidelines:
1. PR Description
2. Tests & Docs
3. Commit Message
"feat: Add embed_options to charts".!for breaking changes (e.g.,"fix!: Raise error when embed_options is None").4. PR Title Types