MAINT: Update from v4 to v5 in some additional files#2582
Merged
joelostblom merged 1 commit intovega:masterfrom Nov 27, 2022
Merged
MAINT: Update from v4 to v5 in some additional files#2582joelostblom merged 1 commit intovega:masterfrom
joelostblom merged 1 commit intovega:masterfrom
Conversation
joelostblom
commented
Mar 28, 2022
| help="local variable name of a pandas DataFrame to be used as the dataset", | ||
| ) | ||
| @magic_arguments.argument("-v", "--version", dest="version", default="5") | ||
| @magic_arguments.argument("-v", "--version", dest="version", default="v5") |
Contributor
Author
There was a problem hiding this comment.
I made this change and the one below so that this will be easier to detect in the future. It was giving me issues initially and it is hard to grep the repo for just the version number without the v prefix.
Contributor
Author
|
@mattijn Does this look OK to you? I think it is mostly cleanup from changing from v4 to v5. |
mattijn
approved these changes
Nov 27, 2022
Contributor
|
I only checked the code-diff and all looks fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I grepped the repo for
v4and noticed a few places where I think it should be replaced withv5. I ran this locally with the updated tests in #2576 and there are no failures introduced.