Skip to content

enhancement(observability): Standardize buffer size metric names#24493

Merged
bruceg merged 2 commits intomasterfrom
bruceg/standardize-buffer-metric-names
Jan 16, 2026
Merged

enhancement(observability): Standardize buffer size metric names#24493
bruceg merged 2 commits intomasterfrom
bruceg/standardize-buffer-metric-names

Conversation

@bruceg
Copy link
Member

@bruceg bruceg commented Jan 13, 2026

Summary

Many of the buffer size metric names have been specified (in docs/specs/buffer.md) in a way that conflicts with the metric naming specification (in docs/specs/instrumentation.md). In particular, the latter specifies that metric names should end with a unit (ex _bytes or _events) but the former placed the units within the name (ex buffer_byte_size or buffer_max_event_size). This latter leads to a confusing metric name which seems to report the maximum event size that may be buffered while in reality it is reporting the maximum size of the buffer in terms of events.

This change adds parallel metrics for these names that provide the standardized names. The existing names are thus deprecated and will be removed in a future version.

Vector configuration

How did you test this PR?

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • make fmt
      • make check-clippy (if there are failures it's possible some of them can be fixed with make clippy-fix)
      • make test
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run make build-licenses to regenerate the license inventory and commit the changes (if any). More details here.

@bruceg bruceg requested review from a team as code owners January 13, 2026 22:15
@bruceg bruceg added the type: enhancement A value-adding code change that enhances its existing functionality. label Jan 13, 2026
@bruceg bruceg requested a review from a team January 13, 2026 22:15
@bruceg bruceg added domain: observability Anything related to monitoring/observing Vector domain: buffers Anything related to Vector's memory/disk buffers labels Jan 13, 2026
@github-actions github-actions bot added domain: external docs Anything related to Vector's external, public documentation domain: core Anything related to core crates i.e. vector-core, core-common, etc labels Jan 13, 2026
@bruceg bruceg force-pushed the bruceg/standardize-buffer-metric-names branch from 85328e6 to b048ffd Compare January 14, 2026 00:01
Many of the buffer size metric names have been specified (in
`docs/specs/buffer.md`) in a way that conflicts with the metric naming
specification (in `docs/specs/instrumentation.md`). In particular, the latter
specifies that metric names should end with a unit (ex `_bytes` or `_events`)
but the former placed the units within the name (ex `buffer_byte_size` or
`buffer_max_event_size`). This latter leads to a confusing metric name which
seems to report the maximum event size that may be buffered while in reality
it is reporting the maximum size of the buffer in terms of events.

This change adds parallel metrics for these names that provide the standardized
names. The existing names are thus deprecated and will be removed in a future
version.
@bruceg bruceg force-pushed the bruceg/standardize-buffer-metric-names branch from b048ffd to 5bf5a93 Compare January 14, 2026 16:52
@bruceg bruceg requested a review from a team as a code owner January 14, 2026 16:52
@bruceg bruceg requested a review from jszwedko January 14, 2026 16:53
Copy link
Contributor

@thomasqueirozb thomasqueirozb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Website renders nicely too and I pushed a commit to add links to the new metrics

@bruceg bruceg enabled auto-merge January 16, 2026 16:03
@bruceg bruceg added this pull request to the merge queue Jan 16, 2026
Merged via the queue into master with commit 3728a4d Jan 16, 2026
68 checks passed
@bruceg bruceg deleted the bruceg/standardize-buffer-metric-names branch January 16, 2026 17:35
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

domain: buffers Anything related to Vector's memory/disk buffers domain: core Anything related to core crates i.e. vector-core, core-common, etc domain: external docs Anything related to Vector's external, public documentation domain: observability Anything related to monitoring/observing Vector domain: website type: enhancement A value-adding code change that enhances its existing functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants