chore: replace anymap with a simple hashmap#19335
Conversation
Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>
Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>
Datadog ReportBranch report: ✅ |
| greptimedb-client = { git = "https://github.com/GreptimeTeam/greptimedb-client-rust.git", rev = "bc32362adf0df17a41a95bae4221d6d8f1775656", optional = true } | ||
|
|
||
| # External libs | ||
| anymap = { version = "0.12", default-features = false } |
Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>
Regression Detector ResultsRun ID: 203f31ad-9b5a-43e5-a25d-a224c975701d Performance changes are noted in the perf column of each table:
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | confidence |
|---|---|---|---|---|---|
| ✅ | file_to_blackhole | egress throughput | +0.97 | [-1.49, +3.44] | 48.45% |
| ✅ | http_to_http_acks | ingress throughput | +0.21 | [-1.10, +1.51] | 20.49% |
| ❌ | splunk_hec_route_s3 | ingress throughput | -0.40 | [-0.92, +0.12] | 79.34% |
| ❌ | fluent_elasticsearch | ingress throughput | -1.87 | [-2.35, -1.39] | 100.00% |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | confidence |
|---|---|---|---|---|---|
| ✅ | syslog_log2metric_humio_metrics | ingress throughput | +4.08 | [+3.93, +4.23] | 100.00% |
| ✅ | otlp_http_to_blackhole | ingress throughput | +2.73 | [+2.59, +2.87] | 100.00% |
| ✅ | datadog_agent_remap_datadog_logs_acks | ingress throughput | +2.54 | [+2.45, +2.63] | 100.00% |
| ✅ | otlp_grpc_to_blackhole | ingress throughput | +2.51 | [+2.41, +2.61] | 100.00% |
| ✅ | syslog_loki | ingress throughput | +2.33 | [+2.27, +2.39] | 100.00% |
| ✅ | http_text_to_http_json | ingress throughput | +2.32 | [+2.18, +2.45] | 100.00% |
| ✅ | socket_to_socket_blackhole | ingress throughput | +2.30 | [+2.22, +2.38] | 100.00% |
| ✅ | syslog_splunk_hec_logs | ingress throughput | +2.05 | [+2.01, +2.10] | 100.00% |
| ✅ | datadog_agent_remap_datadog_logs | ingress throughput | +1.17 | [+1.08, +1.27] | 100.00% |
| ✅ | syslog_humio_logs | ingress throughput | +1.17 | [+1.08, +1.26] | 100.00% |
| ✅ | file_to_blackhole | egress throughput | +0.97 | [-1.49, +3.44] | 48.45% |
| ✅ | syslog_log2metric_tag_cardinality_limit_blackhole | ingress throughput | +0.87 | [+0.74, +0.99] | 100.00% |
| ✅ | datadog_agent_remap_blackhole_acks | ingress throughput | +0.33 | [+0.23, +0.43] | 100.00% |
| ✅ | http_to_http_acks | ingress throughput | +0.21 | [-1.10, +1.51] | 20.49% |
| ✅ | http_to_http_noack | ingress throughput | +0.15 | [+0.06, +0.24] | 99.47% |
| ✅ | datadog_agent_remap_blackhole | ingress throughput | +0.08 | [-0.02, +0.18] | 82.81% |
| ✅ | http_to_http_json | ingress throughput | +0.02 | [-0.05, +0.10] | 41.53% |
| ✅ | splunk_hec_indexer_ack_blackhole | ingress throughput | +0.00 | [-0.14, +0.14] | 1.32% |
| ✅ | splunk_hec_to_splunk_hec_logs_acks | ingress throughput | +0.00 | [-0.14, +0.14] | 0.08% |
| ❌ | splunk_hec_to_splunk_hec_logs_noack | ingress throughput | -0.01 | [-0.12, +0.10] | 12.28% |
| ❌ | syslog_regex_logs2metric_ddmetrics | ingress throughput | -0.03 | [-0.12, +0.06] | 38.95% |
| ❌ | enterprise_http_to_http | ingress throughput | -0.08 | [-0.14, -0.01] | 93.01% |
| ❌ | syslog_log2metric_splunk_hec_metrics | ingress throughput | -0.28 | [-0.41, -0.14] | 99.93% |
| ❌ | splunk_hec_route_s3 | ingress throughput | -0.40 | [-0.92, +0.12] | 79.34% |
| ❌ | http_to_s3 | ingress throughput | -0.42 | [-0.69, -0.14] | 98.69% |
| ❌ | http_elasticsearch | ingress throughput | -1.07 | [-1.14, -1.00] | 100.00% |
| ❌ | fluent_elasticsearch | ingress throughput | -1.87 | [-2.35, -1.39] | 100.00% |
* Replace anymap with a simple hashmap Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Slight tidy Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Still need the license Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> --------- Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>
#18929 introduced a dependency on
anymap, which according to https://rustsec.org/advisories/RUSTSEC-2021-0065.html is unmaintained.This PR removes the dependency and replaces it with a simple
HashMapofTypeId->Any.