-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update OpenTelemetry Protobuf Definitions to v1.0.0 #19188
chore: Update OpenTelemetry Protobuf Definitions to v1.0.0 #19188
Conversation
c1947e3
to
e066125
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Thanks!
@hdost We have some very trivial checks that have failed. Would you be able to amend these:
|
Yup I should be able tomorrow morning. |
This will also make sure that all the necessary files exist for the rest of the signals. Relates vectordotdev#1444 Signed-off-by: Harold Dost <[email protected]>
e066125
to
402da80
Compare
@StephenWakely should be set |
Regression Detector ResultsRun ID: dd0bedfe-e18f-44cc-98c1-c238bae8a620 ExplanationA regression test is an integrated performance test for Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval. We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:
The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed. No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%. Fine details of change detection per experiment.
|
…dev#19188) This will also make sure that all the necessary files exist for the rest of the signals. Relates vectordotdev#1444 Signed-off-by: Harold Dost <[email protected]>
This will also make sure that all the necessary files exist for the rest of the signals.
Relates #1444
Signed-off-by: Harold Dost [email protected]
Not expected to be a breaking change to open-telemetry/opentelemetry-proto#414