-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New opentelemetry
source and sink
#1444
Comments
Looks relevant #576 |
opencensus
source and sinktelemetry
source and sink
telemetry
source and sinkopentelemetry
source and sink
As OpenTracing merged with OpenCensus in one OpenTelemetry project it is considered to support that feature on in and / out ?? |
Thanks @szibis. Agree, that's the idea with thee OpenTelemetry components. We also want them to enforce our tracing data model when we start to implement it.
Agree! That's the primary idea behind Vector. Although, Vector wants to acknowledge current state and help users migrate towards open standards. |
Hi! I'd prefer to have a single agent for all our telemetry needs, but it'd be interesting to understand better 👀 |
Any update? I see that tasks related with opentelemetry were removed from different milestones? |
Hi @KFearsoff 👋 I do have adding metrics support to the existing |
This thread consists of "next quarter". I don't mean any offense to you or the Vector team, but I'd like to take the initiative given the opportunity 😄
I'm particularly interested in tracing source and sink. I don't really care about metrics or logs, but I'm guessing there will be some overlap (like trace -> log transformation). I'd like to get the sources and sinks done before worrying about transforms, though.
I don't mind opening ones 😉 |
No offense taken! I've been disappointed personally with not being able to work on it, but that's just how prioritization goes some times 🙂
It looks like we have a few issues open for transforms:
I'd agree that we need more integrations for receiving and sending trace events before the demands for transforms hits a breaking point. I'm not even sure all of the existing transforms have been updated to support receiving traces.
👍 sounds good! I think adding trace support to the existing I suspect much of the code for trace support should be straight forward, currently the trace data model is identical to our log data model (type wise) so I don't expect there will be too many surprises from the existing log implementation. |
Godspeed @KFearsoff 🫡 |
I'm mostly unsure if it would be best to create a dummy source that would take in traces in the current trace data model, or if it's best to start with changing the trace data model (as described in RFC about OTLP traces). I've considered starting with the trace data model, because I think traces and logs are quite different, but I've looked over it and I think starting with that might be a little too ambitious for me 😅 Not sure if treating traces like logs is fine, though (especially because it would make it quite hard to create a sink). What do you think? I'll join Discord a little bit later, eager to start! |
I think given that's how we're handling Datadog traces today it should be fine, I'd agree that updating the data model is a much bigger task and would require a lot more consensus and coordination. I'll check what the rest of the team thinks and get back to you. |
I'm going to switch over to #17307 for further discussion specific to adding trace support here 👍 |
Hi, is there any updates? Thanks! |
@spencergilbert I'm curious that now vector's OpenTelemetry Source can only ingest logs for now, metrics and traces are not yet supported? |
Hi @benjaminhuo - metrics and traces are not yet supported, but we plan to support metrics in the near future. |
Any updates or timeline here? Looking to build out an observability pipeline, and I was excited to use Vector for everything until I noticed the minimal support for OTel. An option we'll be evaluating now is building the entire observability pipeline with OTel collectors & exporters, since in theory they can handle logs, metrics, and traces (though the support for logs via OTel is still very young). My experimentation with vector for logs has been great so far, and it was a huge disappointment to find that we'll likely need another solution for traces (and maybe metrics). Here's the landscape as I see it: For traces, there's exactly one source (datadog) and one sink (datadog). For metrics, I am primarily interested in capturing (code-instrumented) application metrics. Ignoring the datadog libs/agent for a moment, it seems like my options for getting these into vector are:
Publishing vector-shipped metrics to some endpoint are also a bit limited, but I could probably get by with what's available. The transformations for metrics seem very useful. In particular, the tag cardinality transform seems critical for maintaining downstream health (especially certain DBs). I have yet to find a similar OTel processor, so that's a big selling point for vector metrics, but I'm not sold on the mechanisms for getting metrics into vector. I would love to use OTel. Am I missing something? Has anyone faced a similar situation? My options seem to be: vector for logs (and maybe metrics), OTel for tracing (and maybe metrics)... Or OTel for everything. (I am not sure about the OTel mechanism & data model for logs, though). Reading through the history on this thread, it's hard for me to discount the likelihood that this work will never receive internal prioritization because it's counter to datadog's business model. I get it. Datadog needs to sell datadog. Maybe the answer here is for community contribution, as some folks here have already discussed. It would be great to get an idea on where things stand, so we're not just waiting for Godot. |
Hi @srstrickland, I had barely the same feelings for vector vs otel. Here is my comparison to help the vector team to enhance OTEL support. You will find a comparison and working demo (end to end from signal to grafana dashboard for services and agents https://github.com/cboudereau/consul-demo/blob/main/service-discovery/up.sh). I made this demo during DataDog evaluation where I showed the solution to the DataDog Engineer solution from parsing with agent observability to monitor agents for vector and otelcol-contrib: In our case we choose both but we would like to reduce our complexity. |
This will also make sure that all the necessary files exist for the rest of the signals. Relates vectordotdev#1444 Signed-off-by: Harold Dost <[email protected]>
This will also make sure that all the necessary files exist for the rest of the signals. Relates vectordotdev#1444 Signed-off-by: Harold Dost <[email protected]>
This will also make sure that all the necessary files exist for the rest of the signals. Relates vectordotdev#1444 Signed-off-by: Harold Dost <[email protected]>
I also ran into the same issue. All this time I thought Vector supported OTEL, to find out it only supports part of it. |
This will also make sure that all the necessary files exist for the rest of the signals. Relates #1444 Signed-off-by: Harold Dost <[email protected]>
Provides a path forward for integrating `sources` and `sinks` for Tracing. Relates vectordotdev#1444, vectordotdev#17307, vectordotdev#17308
Any plan to increase priority for implementing full OTEL support? |
…dev#19188) This will also make sure that all the necessary files exist for the rest of the signals. Relates vectordotdev#1444 Signed-off-by: Harold Dost <[email protected]>
This is the most depressing thing I have seen on github in a while. |
Basic support for ingesting logs/metrics/traces was added here. Future work involves gRPC support and native event conversion. Leaving this ticket open until we add support for metrics and traces to the OpenTelemetry source. Then we can close this and the community can start creating more targeted issues for bugs/enhancements. |
Nice. That's a good start. I was more thinking about having source than sink to have Vector in role of aggregator. |
This should work for logs and traces. Did you try it? Not sure how well tested it is. Feel free open a discussion or a new issue. Again, it would be easier if we stopped using this issue as an OpenTelemetry/Vector catch-all. |
Provides a path forward for integrating `sources` and `sinks` for Tracing. Relates vectordotdev#1444, vectordotdev#17307, vectordotdev#17308
OpenTelemetry is a specification for collecting observability data.
Their collector and libraries are of questionable quality. We'd like Vector to support OT through their various protobufs and become the best OT collector.
We should break this down into smaller tasks, likely around their various data type (logs, metrics, and traces). I'd like to start with tracing, if possible, to introduce that type into our data model.
The text was updated successfully, but these errors were encountered: