Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 6 additions & 39 deletions src/sinks/loki/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,42 +9,8 @@ use crate::{
sinks::{prelude::*, util::UriSerde},
};

/// Loki-specific compression.
#[configurable_component]
#[derive(Debug, Copy, Clone, Eq, PartialEq)]
pub enum ExtendedCompression {
/// Snappy compression.
///
/// This implies sending push requests as Protocol Buffers.
#[serde(rename = "snappy")]
Snappy,
}

/// Compression configuration.
#[configurable_component]
#[derive(Debug, Copy, Clone, Eq, PartialEq)]
#[serde(untagged)]
pub enum CompressionConfigAdapter {
/// Basic compression.
Original(Compression),

/// Loki-specific compression.
Extended(ExtendedCompression),
}

impl CompressionConfigAdapter {
pub const fn content_encoding(self) -> Option<&'static str> {
match self {
CompressionConfigAdapter::Original(compression) => compression.content_encoding(),
CompressionConfigAdapter::Extended(_) => Some("snappy"),
}
}
}

impl Default for CompressionConfigAdapter {
fn default() -> Self {
CompressionConfigAdapter::Extended(ExtendedCompression::Snappy)
}
const fn default_compression() -> Compression {
Compression::Snappy
}

fn default_loki_path() -> String {
Expand Down Expand Up @@ -106,9 +72,10 @@ pub struct LokiConfig {
#[serde(default = "crate::serde::default_true")]
pub remove_timestamp: bool,

#[configurable(derived)]
#[serde(default)]
pub compression: CompressionConfigAdapter,
/// Compression configuration.
/// Snappy compression implies sending push requests as Protocol Buffers.
#[serde(default = "default_compression")]
pub compression: Compression,

#[configurable(derived)]
#[serde(default)]
Expand Down
9 changes: 3 additions & 6 deletions src/sinks/loki/service.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ use http::StatusCode;
use snafu::Snafu;
use tracing::Instrument;

use crate::sinks::loki::config::{CompressionConfigAdapter, ExtendedCompression};
use crate::{
http::{Auth, HttpClient},
sinks::{prelude::*, util::UriSerde},
Expand Down Expand Up @@ -60,7 +59,7 @@ impl DriverResponse for LokiResponse {

#[derive(Clone)]
pub struct LokiRequest {
pub compression: CompressionConfigAdapter,
pub compression: Compression,
pub finalizers: EventFinalizers,
pub payload: Bytes,
pub tenant_id: Option<String>,
Expand Down Expand Up @@ -113,10 +112,8 @@ impl Service<LokiRequest> for LokiService {

fn call(&mut self, request: LokiRequest) -> Self::Future {
let content_type = match request.compression {
CompressionConfigAdapter::Original(_) => "application/json",
CompressionConfigAdapter::Extended(ExtendedCompression::Snappy) => {
"application/x-protobuf"
}
Compression::Snappy => "application/x-protobuf",
_ => "application/json",
};
let mut req = http::Request::post(&self.endpoint.uri).header("Content-Type", content_type);

Expand Down
14 changes: 4 additions & 10 deletions src/sinks/loki/sink.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ use super::{
event::{LokiBatchEncoder, LokiEvent, LokiRecord, PartitionKey},
service::{LokiRequest, LokiRetryLogic, LokiService},
};
use crate::sinks::loki::config::{CompressionConfigAdapter, ExtendedCompression};
use crate::sinks::loki::event::LokiBatchEncoding;
use crate::{
http::{get_http_scheme_from_uri, HttpClient},
Expand Down Expand Up @@ -65,7 +64,7 @@ impl Partitioner for RecordPartitioner {

#[derive(Clone)]
pub struct LokiRequestBuilder {
compression: CompressionConfigAdapter,
compression: Compression,
encoder: LokiBatchEncoder,
}

Expand All @@ -92,10 +91,7 @@ impl RequestBuilder<(PartitionKey, Vec<LokiRecord>)> for LokiRequestBuilder {
type Error = RequestBuildError;

fn compression(&self) -> Compression {
match self.compression {
CompressionConfigAdapter::Original(compression) => compression,
CompressionConfigAdapter::Extended(_) => Compression::None,
}
self.compression
}

fn encoder(&self) -> &Self::Encoder {
Expand Down Expand Up @@ -415,10 +411,8 @@ impl LokiSink {
let serializer = config.encoding.build()?;
let encoder = Encoder::<()>::new(serializer);
let batch_encoder = match config.compression {
CompressionConfigAdapter::Original(_) => LokiBatchEncoder(LokiBatchEncoding::Json),
CompressionConfigAdapter::Extended(ExtendedCompression::Snappy) => {
LokiBatchEncoder(LokiBatchEncoding::Protobuf)
}
Compression::Snappy => LokiBatchEncoder(LokiBatchEncoding::Protobuf),
_ => LokiBatchEncoder(LokiBatchEncoding::Json),
};

Ok(Self {
Expand Down
11 changes: 7 additions & 4 deletions website/cue/reference/components/sinks/base/loki.cue
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,11 @@ base: components: sinks: loki: configuration: {
}
}
compression: {
description: "Compression configuration."
required: false
description: """
Compression configuration.
Snappy compression implies sending push requests as Protocol Buffers.
"""
required: false
type: string: {
default: "snappy"
enum: {
Expand All @@ -122,9 +125,9 @@ base: components: sinks: loki: configuration: {
"""
none: "No compression."
snappy: """
Snappy compression.
[Snappy][snappy] compression.

This implies sending push requests as Protocol Buffers.
[snappy]: https://github.com/google/snappy/blob/main/docs/README.md
"""
zlib: """
[Zlib][zlib] compression.
Expand Down