chore(deps): Update VRL to use KeyString type wrapper#19069
Conversation
pront
left a comment
There was a problem hiding this comment.
I don't see any functional changes, just changing types and using .into() vs to_string().
Datadog ReportBranch report: ✅ |
Regression Detector ResultsRun ID: 3f1736ca-9c26-445e-8667-b374f834ee32 ExplanationA regression test is an integrated performance test for Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval. We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:
The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed. No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%. Fine details of change detection per experiment.
|
…#19069) * chore(deps): Update VRL to use `KeyString` type wrapper * Revert unnecessary slice expression
…#19069) * chore(deps): Update VRL to use `KeyString` type wrapper * Revert unnecessary slice expression
This bumps the VRL rev to the commit introducing the
KeyStringtype wrapper and updates the code to match the new types. Mostly this involves a lot of.into()but there are a few type changes as well. I am putting this out in advance of the VRL release as I had most of the changes done already and it will quickly get out of date again. This should be performance-neutral at this point.