Skip to content

chore(perf): Update VRL to use experimental KeyString type#18898

Closed
bruceg wants to merge 1 commit intomasterfrom
bruceg/vrl-experiment
Closed

chore(perf): Update VRL to use experimental KeyString type#18898
bruceg wants to merge 1 commit intomasterfrom
bruceg/vrl-experiment

Conversation

@bruceg
Copy link
Member

@bruceg bruceg commented Oct 20, 2023

This is an experiment I've been working on in the background for a bit. Putting this here to run it through the SMP regression testing.

@bruceg bruceg added type: tech debt A code change that does not add user value. domain: performance Anything related to Vector's performance ci-condition: skip labels Oct 20, 2023
@netlify
Copy link

netlify bot commented Oct 20, 2023

Deploy Preview for vector-project ready!

Name Link
🔨 Latest commit c7a54c1
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/6532cf853c806100083d09e3
😎 Deploy Preview https://deploy-preview-18898--vector-project.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 20, 2023

Deploy Preview for vrl-playground ready!

Name Link
🔨 Latest commit c7a54c1
🔍 Latest deploy log https://app.netlify.com/sites/vrl-playground/deploys/6532cf8502ef5f00081df61c
😎 Deploy Preview https://deploy-preview-18898--vrl-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added domain: sources Anything related to the Vector's sources domain: transforms Anything related to Vector's transform components domain: sinks Anything related to the Vector's sinks domain: codecs Anything related to Vector's codecs (encoding/decoding) domain: core Anything related to core crates i.e. vector-core, core-common, etc labels Oct 20, 2023
@bruceg
Copy link
Member Author

bruceg commented Oct 20, 2023

/ci-run-regression

@github-actions
Copy link

Regression Detector Results

Run ID: 4ca0ca0d-1269-483d-81b8-cdd10c1d1d92
Baseline: 7a55e54
Comparison: c7a54c1
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine quickly if vector performance is changed and to what degree by a pull request.

Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval.

We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:

  1. The estimated |Δ mean %| ≥ 5.00%. This criterion intends to answer the question "Does the estimated change in mean optimization goal performance have a meaningful impact on your customers?". We assume that when |Δ mean %| < 5.00%, the impact on your customers is not meaningful. We also assume that a performance change in optimization goal is worth investigating whether it is an increase or decrease, so long as the magnitude of the change is sufficiently large.

  2. Zero is not in the 90.00% confidence interval "Δ mean % CI" about "Δ mean %". This statement is equivalent to saying that there is at least a 90.00% chance that the mean difference in optimization goal is not zero. This criterion intends to answer the question, "Is there a statistically significant difference in mean optimization goal performance?". It also means there is no more than a 10.00% chance this criterion reports a statistically significant difference when the true difference in mean optimization goal is zero -- a "false positive". We assume you are willing to accept a 10.00% chance of inaccurately detecting a change in performance when no true difference exists.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

Changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%:

experiment goal Δ mean % confidence
http_to_http_acks ingress throughput +15.27 100.00%
fluent_elasticsearch ingress throughput +5.95 100.00%
Fine details of change detection per experiment.
experiment goal Δ mean % Δ mean % CI confidence
http_to_http_acks ingress throughput +15.27 [+13.96, +16.59] 100.00%
fluent_elasticsearch ingress throughput +5.95 [+5.49, +6.41] 100.00%
splunk_hec_route_s3 ingress throughput +4.07 [+3.51, +4.62] 100.00%
syslog_humio_logs ingress throughput +3.72 [+3.60, +3.84] 100.00%
http_text_to_http_json ingress throughput +3.29 [+3.14, +3.43] 100.00%
socket_to_socket_blackhole ingress throughput +2.80 [+2.73, +2.86] 100.00%
http_to_s3 ingress throughput +2.11 [+1.82, +2.40] 100.00%
otlp_http_to_blackhole ingress throughput +1.53 [+1.37, +1.68] 100.00%
syslog_log2metric_humio_metrics ingress throughput +1.27 [+1.13, +1.41] 100.00%
syslog_loki ingress throughput +1.21 [+1.14, +1.27] 100.00%
syslog_splunk_hec_logs ingress throughput +0.97 [+0.85, +1.08] 100.00%
file_to_blackhole egress throughput +0.76 [-1.71, +3.23] 38.83%
syslog_log2metric_splunk_hec_metrics ingress throughput +0.58 [+0.43, +0.73] 100.00%
http_to_http_noack ingress throughput +0.08 [+0.00, +0.17] 90.70%
datadog_agent_remap_datadog_logs_acks ingress throughput +0.03 [-0.11, +0.17] 26.30%
splunk_hec_to_splunk_hec_logs_acks ingress throughput +0.02 [-0.12, +0.17] 20.11%
http_to_http_json ingress throughput +0.00 [-0.04, +0.05] 15.36%
splunk_hec_indexer_ack_blackhole ingress throughput -0.00 [-0.17, +0.16] 3.52%
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.03 [-0.16, +0.09] 32.90%
enterprise_http_to_http ingress throughput -0.06 [-0.14, +0.02] 78.45%
datadog_agent_remap_blackhole_acks ingress throughput -0.38 [-0.49, -0.26] 100.00%
datadog_agent_remap_blackhole ingress throughput -0.48 [-0.62, -0.34] 100.00%
datadog_agent_remap_datadog_logs ingress throughput -1.69 [-1.87, -1.51] 100.00%
otlp_grpc_to_blackhole ingress throughput -1.79 [-1.90, -1.67] 100.00%
syslog_regex_logs2metric_ddmetrics ingress throughput -1.99 [-2.37, -1.61] 100.00%

@bruceg
Copy link
Member Author

bruceg commented Oct 26, 2023

/ci-run-regression

@github-actions
Copy link

Regression Detector Results

Run ID: 1d2484b9-6bbe-49dc-9c43-56548953e9c3
Baseline: 7a55e54
Comparison: c7a54c1
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine quickly if vector performance is changed and to what degree by a pull request.

Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval.

We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:

  1. The estimated |Δ mean %| ≥ 5.00%. This criterion intends to answer the question "Does the estimated change in mean optimization goal performance have a meaningful impact on your customers?". We assume that when |Δ mean %| < 5.00%, the impact on your customers is not meaningful. We also assume that a performance change in optimization goal is worth investigating whether it is an increase or decrease, so long as the magnitude of the change is sufficiently large.

  2. Zero is not in the 90.00% confidence interval "Δ mean % CI" about "Δ mean %". This statement is equivalent to saying that there is at least a 90.00% chance that the mean difference in optimization goal is not zero. This criterion intends to answer the question, "Is there a statistically significant difference in mean optimization goal performance?". It also means there is no more than a 10.00% chance this criterion reports a statistically significant difference when the true difference in mean optimization goal is zero -- a "false positive". We assume you are willing to accept a 10.00% chance of inaccurately detecting a change in performance when no true difference exists.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

Changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%:

experiment goal Δ mean % confidence
http_to_http_acks ingress throughput +15.79 100.00%
Fine details of change detection per experiment.
experiment goal Δ mean % Δ mean % CI confidence
http_to_http_acks ingress throughput +15.79 [+14.48, +17.10] 100.00%
fluent_elasticsearch ingress throughput +4.56 [+4.11, +5.01] 100.00%
socket_to_socket_blackhole ingress throughput +4.12 [+4.04, +4.19] 100.00%
http_text_to_http_json ingress throughput +4.03 [+3.91, +4.15] 100.00%
syslog_log2metric_humio_metrics ingress throughput +3.84 [+3.76, +3.92] 100.00%
splunk_hec_route_s3 ingress throughput +2.43 [+1.92, +2.93] 100.00%
http_to_s3 ingress throughput +2.01 [+1.73, +2.30] 100.00%
syslog_humio_logs ingress throughput +1.72 [+1.63, +1.81] 100.00%
syslog_loki ingress throughput +1.44 [+1.40, +1.48] 100.00%
syslog_regex_logs2metric_ddmetrics ingress throughput +0.97 [+0.71, +1.23] 100.00%
syslog_log2metric_splunk_hec_metrics ingress throughput +0.72 [+0.59, +0.85] 100.00%
datadog_agent_remap_datadog_logs_acks ingress throughput +0.51 [+0.44, +0.59] 100.00%
datadog_agent_remap_blackhole ingress throughput +0.49 [+0.40, +0.57] 100.00%
otlp_http_to_blackhole ingress throughput +0.46 [+0.31, +0.61] 100.00%
syslog_splunk_hec_logs ingress throughput +0.21 [+0.15, +0.26] 100.00%
datadog_agent_remap_blackhole_acks ingress throughput +0.18 [+0.09, +0.27] 99.93%
http_to_http_noack ingress throughput +0.15 [+0.05, +0.24] 98.92%
http_to_http_json ingress throughput +0.01 [-0.04, +0.05] 16.19%
splunk_hec_to_splunk_hec_logs_acks ingress throughput -0.00 [-0.15, +0.14] 1.79%
datadog_agent_remap_datadog_logs ingress throughput -0.01 [-0.10, +0.09] 8.46%
splunk_hec_indexer_ack_blackhole ingress throughput -0.01 [-0.15, +0.13] 6.37%
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.03 [-0.15, +0.09] 33.22%
enterprise_http_to_http ingress throughput -0.07 [-0.16, +0.01] 85.13%
file_to_blackhole egress throughput -0.20 [-2.65, +2.26] 10.42%
otlp_grpc_to_blackhole ingress throughput -2.59 [-2.68, -2.49] 100.00%

@bruceg
Copy link
Member Author

bruceg commented Nov 6, 2023

Superseded by #19069

@bruceg bruceg closed this Nov 6, 2023
@bruceg bruceg deleted the bruceg/vrl-experiment branch November 6, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: codecs Anything related to Vector's codecs (encoding/decoding) domain: core Anything related to core crates i.e. vector-core, core-common, etc domain: performance Anything related to Vector's performance domain: sinks Anything related to the Vector's sinks domain: sources Anything related to the Vector's sources domain: transforms Anything related to Vector's transform components type: tech debt A code change that does not add user value.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant