-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server Offline Activity Indicator #5607
Comments
@niquewoodhouse is this design good enough for you? Also should we keep the error message in the room view at the bottom of the screen or should we change it? Another possible screen for changes: |
Does this remain visible for as long as the connection is off? Does it appear each time you try to do something that involves accessing the internet and then disappear? In terms of design, would prefer to change icon + copy so its more concise and clearly about the internet.
|
As off now the nudge remains visible only for 1s. I just enhanced the "You're offline, check your Wi-Fi connection" is quite long and Wi-Fi is not generic enough. What about "You're offline, check your connection"? |
Sounds good to me, thanks.
When it does it appear? is it everyone you try to do something that involves a connection? 1s might be short but I trust we can get feedback on that later. Not sure when this appears vs the indicator but maybe changing the copy is enough. Title: You're offline
Yes I think we should keep it. Not because I think its specifically good or anything, it's just what happens on the other platforms so consistency seems right when showing errors. |
As per our discussion earlier, we committed to change the copy for Here is how the application could behave if the device is offline: |
Thanks @gileluard I think we should go ship this. It does mean iOS will be different to web and android, in the way it communicates if you're offline but I believe this is an improvement for the following reasons:
cc @nadonomy (just letting you know about this tweak). @amshakal you may wish to amend this depending on what happens with IA |
@niquewoodhouse @gileluard thanks for tagging! @amshakal actually found a more elegant place for it in the bottom bar, but that's pending the next app layout changes, and might not apply to the room view too. I like how this works. @niquewoodhouse there's a part of me that thinks it might look less messy if it's sat beneath the header rather than overlapping. I'm used that from apps like Twitter, 'jump to' interactions on chat apps, and interactions like pull to refresh. Wdyt? |
@amshakal do you have a rough idea of when the next app layout changes might land, to help estimate if this worth fixing for now?
I think if it's beneath you might miss it in practice but it could work well wdyt @nadonomy |
Thank you @amshakal! @gileluard it sounds like the possible change might not happen so I think it would be good to go ahead with your PR, unless you feel otherwise. The final requested design changes are:
|
We use the same |
Yes, I think so thank you for asking and giving me the time to check. |
Use ActivityCenter to implement "server offline" and "no connection" activity indicators. See #4829 for further context.
Figma designs
The text was updated successfully, but these errors were encountered: