Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server Offline Activity Indicator #5607

Closed
Anderas opened this issue Feb 16, 2022 · 12 comments · Fixed by #6314
Closed

Server Offline Activity Indicator #5607

Anderas opened this issue Feb 16, 2022 · 12 comments · Fixed by #6314
Assignees
Labels
A-Activity-Indicators Unifying the activity indicator style across the app T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-WTF WTF issues: High impact, Low Effort

Comments

@Anderas
Copy link
Contributor

Anderas commented Feb 16, 2022

Use ActivityCenter to implement "server offline" and "no connection" activity indicators. See #4829 for further context.

Figma designs

@Anderas Anderas added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements A-Activity-Indicators Unifying the activity indicator style across the app labels Feb 16, 2022
@Anderas Anderas added the Z-WTF WTF issues: High impact, Low Effort label Feb 28, 2022
@gileluard
Copy link
Contributor

gileluard commented Jun 7, 2022

@niquewoodhouse is this design good enough for you?

Image

Also should we keep the error message in the room view at the bottom of the screen or should we change it?

Image

Another possible screen for changes:

Simulator Screen Shot - iPhone 12 Pro - 2022-06-07 at 11 07 43

@niquewoodhouse
Copy link

Does this remain visible for as long as the connection is off? Does it appear each time you try to do something that involves accessing the internet and then disappear?

In terms of design, would prefer to change icon + copy so its more concise and clearly about the internet.

  • For example, using wifi.slash in symbols instead of the error icon.

image

  • Updating copy to be "You're offline, check your Wi-Fi connection"

@gileluard
Copy link
Contributor

As off now the nudge remains visible only for 1s. I just enhanced the ActivityCenter to display also error messages. The behaviour is similar to the one implemented for completion messages.

"You're offline, check your Wi-Fi connection" is quite long and Wi-Fi is not generic enough. What about "You're offline, check your connection"?

@niquewoodhouse
Copy link

"You're offline, check your Wi-Fi connection" is quite long and Wi-Fi is not generic enough. What about "You're offline, check your connection"?

Sounds good to me, thanks.

As off now the nudge remains visible only for 1s. I just enhanced the ActivityCenter to display also error messages. The behaviour is similar to the one implemented for completion messages.

When it does it appear? is it everyone you try to do something that involves a connection? 1s might be short but I trust we can get feedback on that later.

Not sure when this appears vs the indicator but maybe changing the copy is enough.

Title: You're offline
Body: You're offline, check your connection.

Also should we keep the error message in the room view at the bottom of the screen or should we change it?

Yes I think we should keep it. Not because I think its specifically good or anything, it's just what happens on the other platforms so consistency seems right when showing errors.

@gileluard gileluard self-assigned this Jun 9, 2022
@gileluard
Copy link
Contributor

@niquewoodhouse

As per our discussion earlier, we committed to change the copy for You're offline, keep the nudge all over the application while the application is not connected to the internet. Therefore we have a double notification in the room screen and decided to remove the bottom one in order to be consistent all over the application:

Screen Shot 2022-06-17 at 11 14 14

Here is how the application could behave if the device is offline:

ezgif-2-7366610399

@niquewoodhouse
Copy link

niquewoodhouse commented Jun 17, 2022

Thanks @gileluard

I think we should go ship this. It does mean iOS will be different to web and android, in the way it communicates if you're offline but I believe this is an improvement for the following reasons:

  • Using same component for showing syncing activity, so user is familiar with these indicators for explaining status
  • Persistent across the app, so users will be able to see a reason for actions not being completed (eg - changing avatar, inviting someone to room), not just visible when viewing a timeline.

cc @nadonomy (just letting you know about this tweak). @amshakal you may wish to amend this depending on what happens with IA

@nadonomy
Copy link
Contributor

@niquewoodhouse @gileluard thanks for tagging!

@amshakal actually found a more elegant place for it in the bottom bar, but that's pending the next app layout changes, and might not apply to the room view too.

I like how this works. @niquewoodhouse there's a part of me that thinks it might look less messy if it's sat beneath the header rather than overlapping. I'm used that from apps like Twitter, 'jump to' interactions on chat apps, and interactions like pull to refresh. Wdyt?

@niquewoodhouse
Copy link

@amshakal actually found a more elegant place for it in the bottom bar, but that's pending the next app layout changes, and might not apply to the room view too.

@amshakal do you have a rough idea of when the next app layout changes might land, to help estimate if this worth fixing for now?

I like how this works. @niquewoodhouse there's a part of me that thinks it might look less messy if it's sat beneath the header rather than overlapping. I'm used that from apps like Twitter, 'jump to' interactions on chat apps, and interactions like pull to refresh. Wdyt?

I think if it's beneath you might miss it in practice but it could work well wdyt @nadonomy

image

@amshakal
Copy link

amshakal commented Jun 30, 2022

We have been debating having a bottom bar like this on home screen, thsi space would be used to add status messages but it won't be there on other screens so maybe it's not that scalable and what you have here is.

Screenshot 2022-06-30 at 5 13 41 pm

@niquewoodhouse
Copy link

Thank you @amshakal! @gileluard it sounds like the possible change might not happen so I think it would be good to go ahead with your PR, unless you feel otherwise.

The final requested design changes are:

  • move the indicator down so it sits underneath the header
  • use System as the background colour (reference link)

@gileluard
Copy link
Contributor

@niquewoodhouse

move the indicator down so it sits underneath the header

We use the same userIndicator in the application. Moving it down will imply to move down all messages with the same look & feel. Is it ok for you?

@niquewoodhouse
Copy link

@niquewoodhouse

move the indicator down so it sits underneath the header

We use the same userIndicator in the application. Moving it down will imply to move down all messages with the same look & feel. Is it ok for you?

Yes, I think so thank you for asking and giving me the time to check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Activity-Indicators Unifying the activity indicator style across the app T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-WTF WTF issues: High impact, Low Effort
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants