Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CommonKit and Activity #5585

Merged
merged 2 commits into from
Feb 15, 2022
Merged

Add CommonKit and Activity #5585

merged 2 commits into from
Feb 15, 2022

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Feb 15, 2022

Relates to #4829

Create a new local CommonKit framework that contains Activity and ActivityCenter, to be used by a future PR to display activity indicators, info and error messages. The idea behind an activity is that it encapsulates the state of some temporary UI, and may be added to a queue of multiple activities, only showing one at a time.

CommonKit is a separate framework, so it is easier and faster to build and run tests against, thus making it easier to do TDD. In the future the framework may be extracted to a separate repo if used by other clients / projects

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/zDU2vt

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants