Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Activity Indicator #4829

Closed
pixlwave opened this issue Sep 14, 2021 · 3 comments · Fixed by #5580
Closed

Update the Activity Indicator #4829

pixlwave opened this issue Sep 14, 2021 · 3 comments · Fixed by #5580
Assignees
@Anderas
Labels
A-Activity-Indicators Unifying the activity indicator style across the app T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-D1 Issues that can impact the Day-2 retention Z-Impact-2 Z-Papercuts Visible. Impactful. Predictable to action. Z-Visibility-1

Comments

@pixlwave
Copy link
Member

pixlwave commented Sep 14, 2021 •
edited
Loading

We have a grey activity indicator available on all screens that can be used to show when an operation is in progress. The design of this is very old and in need of a refresh.

There are many use cases of the indicator, and likely some of these should be handled differently to others, for example in the room lists and timeline, it would be desirable for the view to not become obscured with options such as #4614 and #2389

For other use cases having the indicator obscure the view is probably still the best solution.

The current design for reference:
screenshot
@pixlwave pixlwave added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Design May require input from the design team Z-Papercuts Visible. Impactful. Predictable to action. Z-Visibility-1 Z-Impact-2 labels Sep 14, 2021
@niquewoodhouse niquewoodhouse removed the X-Needs-Design May require input from the design team label Oct 12, 2021
@daniellekirkwood daniellekirkwood added the Z-D1 Issues that can impact the Day-2 retention label Oct 18, 2021
@pixlwave
Copy link
Member Author

pixlwave commented Oct 19, 2021 •
edited
Loading

Figma link: https://www.figma.com/file/oOOH24dJVaAvesomUMjxiK/?node-id=19%3A20

@niquewoodhouse
Copy link

Additionally, if server offline: https://www.figma.com/file/oOOH24dJVaAvesomUMjxiK/%5BiOS%5D-Activity-indicator?node-id=101%3A5899

@pixlwave pixlwave mentioned this issue Jan 11, 2022
Open
This was referenced Feb 14, 2022
Merged
Merged
@Anderas
Copy link
Contributor

Anderas commented Feb 16, 2022

Resolved for a single screen only (home). Other screens will be captured by separate issues

@Anderas Anderas added the A-Activity-Indicators Unifying the activity indicator style across the app label Feb 16, 2022
This was referenced Feb 16, 2022
Closed
Closed
Closed
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Anderas Anderas

Labels
A-Activity-Indicators Unifying the activity indicator style across the app T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-D1 Issues that can impact the Day-2 retention Z-Impact-2 Z-Papercuts Visible. Impactful. Predictable to action. Z-Visibility-1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new loading indicator on Home screen element-hq/element-ios
4 participants
@niquewoodhouse @Anderas @pixlwave @daniellekirkwood